Code

Feature/second round audit review#79

Code

Closed

kovalgek wants to merge 167 commits intomainlidofinance/lido-l2:mainfrom feature/second_round_audit_reviewlidofinance/lido-l2-with-steth:feature/second_round_audit_reviewCopy head branch name to clipboard

+19,448-39,389

Commits

Commits on Oct 10, 2023

• create new contract that represents stETH on L2

  kovalgek

  committed
  3256d9f

  Copy full SHA for 3256d9f

Commits on Oct 11, 2023

• add wrap/unwrap functions

  kovalgek

  committed
  e4b2cbd

  Copy full SHA for e4b2cbd

Commits on Oct 13, 2023

• add shares to rebasable token

  kovalgek

  committed
  82038ea

  Copy full SHA for 82038ea

Commits on Oct 17, 2023

• add unit tests

  kovalgek

  committed
  380caaa

  Copy full SHA for 380caaa

Commits on Nov 4, 2023

• add deposit flow for new rebasable token

  kovalgek

  committed
  eab8718

  Copy full SHA for eab8718

Commits on Nov 5, 2023

• add withdraw flow for rebasable token on optimism

  kovalgek

  committed
  c3bc0db

  Copy full SHA for c3bc0db

Commits on Nov 9, 2023

• send rate in data and time during deposit flow

  kovalgek

  committed
  eb98d0b

  Copy full SHA for eb98d0b

• add possibility to depost 0 tokens

  kovalgek

  committed
  800e33f

  Copy full SHA for 800e33f

• init structs

  kovalgek

  committed
  d9ac556

  Copy full SHA for d9ac556

Commits on Dec 11, 2023

• add comments

  kovalgek

  committed
  ddb9ca3

  Copy full SHA for ddb9ca3

• add gas test

  kovalgek

  committed
  a73bcf4

  Copy full SHA for a73bcf4

Commits on Dec 12, 2023

• update gas test

  kovalgek

  committed
  6d37edc

  Copy full SHA for 6d37edc

Commits on Dec 16, 2023

• fix tests

  kovalgek

  committed
  8098fe1

  Copy full SHA for 8098fe1

Commits on Dec 20, 2023

• add token rate oracle

  kovalgek

  committed
  3335339

  Copy full SHA for 3335339

Commits on Dec 24, 2023

• add tests for new token, renaming

  kovalgek

  committed
  86037dc

  Copy full SHA for 86037dc

Commits on Dec 27, 2023

• simplify oracle, remove warnings

  kovalgek

  committed
  86788b2

  Copy full SHA for 86788b2

Commits on Dec 28, 2023

• update unit tests for token rate oracle

  kovalgek

  committed
  ddffe1f

  Copy full SHA for ddffe1f

Commits on Jan 9, 2024

• fix integration tests for rebasable token

  kovalgek

  committed
  7c79d2d

  Copy full SHA for 7c79d2d

• Merge branch 'main' into feature/add_stETH_token_to_optimism

  kovalgek

  committed
  6174943

  Copy full SHA for 6174943

• add test for push token rate method

  kovalgek

  committed
  f0b891a

  Copy full SHA for f0b891a

• unused return values fix

  kovalgek

  committed
  e314bb1

  Copy full SHA for e314bb1

• fix deployment scripts for new oracle and token

  kovalgek

  committed
  4b56ccf

  Copy full SHA for 4b56ccf

Commits on Jan 10, 2024

• add hearbeat to oracle

  kovalgek

  committed
  3b82da7

  Copy full SHA for 3b82da7

Commits on Jan 22, 2024

• pr fixes from first rount review: apply unstructured storage in token, rename consts, rename variables, fix comments

  kovalgek

  committed
  171db5a

  Copy full SHA for 171db5a

Commits on Jan 29, 2024

• PR fixes: fix comments, rename interface, abstract wst

  kovalgek

  committed
  76b4ff3

  Copy full SHA for 76b4ff3

Commits on Feb 2, 2024

• use real implemnations of non rebasable token and oracle contracts in rebnasable token tests

  kovalgek

  committed
  7abf60f

  Copy full SHA for 7abf60f

Commits on Feb 8, 2024

• update unit tests for bridges

  kovalgek

  committed
  707da9b

  Copy full SHA for 707da9b

Commits on Feb 13, 2024

• fix evetns + formating

  kovalgek

  committed
  1cb344a

  Copy full SHA for 1cb344a

Commits on Feb 29, 2024

• Merge branch 'main' into feature/add_stETH_token_to_optimism

  kovalgek

  committed
  f9463f0

  Copy full SHA for f9463f0

Commits on Mar 6, 2024

• move token rate to the base contract

  kovalgek

  committed
  3fd1e94

  Copy full SHA for 3fd1e94

• use inheritance for token rate in l1 bridge, fix e2e tests

  kovalgek

  committed
  66b2501

  Copy full SHA for 66b2501

• add rebasable token e2e tests

  kovalgek

  committed
  7badd9e

  Copy full SHA for 7badd9e

• add bridging-to e2e tests for rebasable token

  kovalgek

  committed
  72bc8f3

  Copy full SHA for 72bc8f3

Commits on Mar 7, 2024

• add token rate observer

  kovalgek

  committed
  83e292b

  Copy full SHA for 83e292b

Commits on Mar 14, 2024

• add observers array

  kovalgek

  committed
  dbf2f92

  Copy full SHA for dbf2f92

Commits on Mar 18, 2024

• add factory and tests

  kovalgek

  committed
  47c50c6

  Copy full SHA for 47c50c6

Commits on Mar 19, 2024

• add unit tests for notifier

  kovalgek

  committed
  7e45410

  Copy full SHA for 7e45410

Commits on Mar 22, 2024

• add token rate pusher

  kovalgek

  committed
  55111b8

  Copy full SHA for 55111b8

• update unit tests for token rate oracle

  kovalgek

  committed
  d99a52f

  Copy full SHA for d99a52f

• remove observer array

  kovalgek

  committed
  fb3eb40

  Copy full SHA for fb3eb40

• fix token rate publicher and notifier unit tests

  kovalgek

  committed
  b167ebd

  Copy full SHA for b167ebd

• fix small comments from PR review

  kovalgek

  committed
  55d2e3f

  Copy full SHA for 55d2e3f

Commits on Mar 27, 2024

• feat(steth): intermediate work on adding ERC-2612/EIP-1271 permit

  arwer13

  committed
  13712ca

  Copy full SHA for 13712ca

Commits on Mar 29, 2024

• update optimism sdk version to fix integration tests

  kovalgek

  committed
  6a46704

  Copy full SHA for 6a46704

• update addresses to run e2e tests

  kovalgek

  committed
  b9d5e56

  Copy full SHA for b9d5e56

• fix integration test

  kovalgek

  committed
  a3f4544

  Copy full SHA for a3f4544

Commits on Apr 1, 2024

• deployment scripts

  kovalgek

  committed
  e2c29e0

  Copy full SHA for e2c29e0

• Merge branch 'feature/add_stETH_token_to_optimism' into feat/steth-permit

  arwer13

  committed
  d28d53d

  Copy full SHA for d28d53d

• add token rate oracle integration tests

  kovalgek

  committed
  0d2df1d

  Copy full SHA for 0d2df1d

Commits on Apr 2, 2024

• fix happy path test for permit for rebasable

  arwer13

  committed
  8dc246e

  Copy full SHA for 8dc246e

• test(rebasable permit): move the rest tests from core stethpermit.test.js

  arwer13

  committed
  ba0b41e

  Copy full SHA for ba0b41e

• add e2e tests for oracle

  kovalgek

  committed
  18a1dc5

  Copy full SHA for 18a1dc5

• Merge pull request lidofinance#74 from lidofinance/feat/steth-permit

  Show description for 624219c
  kovalgek

  authored
  624219c

  Copy full SHA for 624219c

Commits on Apr 3, 2024

• remove increaseAllowance and decreaseAllowance from tokens

  kovalgek

  committed
  5f86091

  Copy full SHA for 5f86091

• change function names

  kovalgek

  committed
  cc868ef

  Copy full SHA for cc868ef

• rename stETH to rebasable token in env

  kovalgek

  committed
  06d00c7

  Copy full SHA for 06d00c7

Commits on Apr 8, 2024

• deploy all script, refactor other deploy scripts

  kovalgek

  committed
  0b22b0f

  Copy full SHA for 0b22b0f

Commits on Apr 9, 2024

• add permit to non-rebasable token

  kovalgek

  committed
  f563fab

  Copy full SHA for f563fab

Commits on Apr 10, 2024

• add unit tests for non-rebasable token

  kovalgek

  committed
  3332e30

  Copy full SHA for 3332e30

• PR fixes: fix comments, readme, rename bridges, notifier refactoring

  kovalgek

  committed
  0545e33

  Copy full SHA for 0545e33

Commits on Apr 15, 2024

• use mapping for tokens in bridges

  kovalgek

  committed
  a55b5f0

  Copy full SHA for a55b5f0

• fix bridge unit and integration tests, remove mapping in storing tokens in bridge

  kovalgek

  committed
  f54eecd

  Copy full SHA for f54eecd

• fix scripts

  kovalgek

  committed
  bc1c56f

  Copy full SHA for bc1c56f

• PR fixes: add comments, rename constracts, more interfaces to contract files

  kovalgek

  committed
  b62fbee

  Copy full SHA for b62fbee

Commits on Apr 16, 2024

• Bump undici from 5.26.3 to 5.28.4

  Show description for 11c2b04
  dependabot[bot]

  authored
  11c2b04

  Copy full SHA for 11c2b04

• remove arbitrum folders

  kovalgek

  committed
  d13586b

  Copy full SHA for d13586b

• remove arbitrum in configs and scripts

  kovalgek

  committed
  ac8e584

  Copy full SHA for ac8e584

• PR fixes: rename tokens, add sanity check to oracle update, add unit tests, fix comments

  kovalgek

  committed
  f387de6

  Copy full SHA for f387de6

Commits on Apr 17, 2024

• remove goerli leftovers, 0.6.11 solidity config

  kovalgek

  committed
  135968a

  Copy full SHA for 135968a

• Merge pull request #2 from lidofinance/remove_arbitrum

  Show description for 83dbf25
  TheDZhon

  authored
  83dbf25

  Copy full SHA for 83dbf25

• fix: Make storage-layout up to date

  TheDZhon

  authored
  d4672ae

  Copy full SHA for d4672ae

• Merge pull request #6 from lidofinance/update-storage-layout-main

  Show description for c721357
  TheDZhon

  authored
  c721357

  Copy full SHA for c721357

• Merge pull request #1 from lidofinance/dependabot/npm_and_yarn/undici-5.28.4

  Show description for d09fa77
  TheDZhon

  authored
  d09fa77

  Copy full SHA for d09fa77

• Merge branch 'main' into feature/rebasable_token

  kovalgek

  committed
  171f19b

  Copy full SHA for 171f19b

• remove arbitrum leftovers after mergin

  kovalgek

  committed
  06768b6

  Copy full SHA for 06768b6

• update package lock

  kovalgek

  committed
  5d26aab

  Copy full SHA for 5d26aab

• Merge branch 'main' into feature/rebasable_token

  kovalgek

  committed
  e587c93

  Copy full SHA for e587c93

• fix: Make storage-layout up to date

  TheDZhon

  authored
  6a5257d

  Copy full SHA for 6a5257d

• Merge pull request #8 from lidofinance/update-storage-layout-feature/rebasable_token

  Show description for b1963d3
  TheDZhon

  authored
  b1963d3

  Copy full SHA for b1963d3

• fix: update npm locks

  TheDZhon

  committed
  ea6fcd7

  Copy full SHA for ea6fcd7

• use unstrucured storage in PermitExtension, add initializers to permit tokens, tests

  kovalgek

  committed
  0ef8c86

  Copy full SHA for 0ef8c86

• remove OZ 4.9

  kovalgek

  committed
  e2cf92f

  Copy full SHA for e2cf92f

• remove unused contract

  kovalgek

  committed
  fa0fc29

  Copy full SHA for fa0fc29

• refactor bridges

  kovalgek

  committed
  429aa7e

  Copy full SHA for 429aa7e

• remove unused function

  kovalgek

  committed
  68066b9

  Copy full SHA for 68066b9

• set default value in config example

  kovalgek

  committed
  84ed665

  Copy full SHA for 84ed665

• use unstructured storage in token rate oracle

  kovalgek

  committed
  58fb55f

  Copy full SHA for 58fb55f

Commits on Apr 18, 2024

• add transferShares and transferSharesFrom to rebasable token, unit tests

  kovalgek

  committed
  4ac5b44

  Copy full SHA for 4ac5b44

Commits on Apr 21, 2024

• add Versioned contract

  kovalgek

  committed
  1cf4329

  Copy full SHA for 1cf4329

• disable initializers

  kovalgek

  committed
  16b6484

  Copy full SHA for 16b6484

• disable initializers for bridges

  kovalgek

  committed
  b6dd6a2

  Copy full SHA for b6dd6a2

• rename variables

  kovalgek

  committed
  f310a3e

  Copy full SHA for f310a3e

• fix tests

  kovalgek

  committed
  1b8cd59

  Copy full SHA for 1b8cd59

• change filters for updating token rate

  kovalgek

  committed
  0e222ec

  Copy full SHA for 0e222ec

Commits on Apr 22, 2024

• fix initilization

  kovalgek

  committed
  4d16767

  Copy full SHA for 4d16767

• fix token rate oracle according to feedback

  kovalgek

  committed
  fad1a4e

  Copy full SHA for fad1a4e

• fix token rate uptading conditions, add tests for initializer

  kovalgek

  committed
  3f2ef87

  Copy full SHA for 3f2ef87

Commits on Apr 23, 2024

• update scripts and tests

  kovalgek

  committed
  c10f864

  Copy full SHA for c10f864

• fix: Make storage-layout up to date

  TheDZhon

  authored
  8518ca1

  Copy full SHA for 8518ca1

• small fixes and init tests

  kovalgek

  committed
  c3e8b9e

  Copy full SHA for c3e8b9e

• Merge pull request #9 from lidofinance/update-storage-layout-feature/rebasable_token

  Show description for f2ff45e
  TheDZhon

  authored
  f2ff45e

  Copy full SHA for f2ff45e

Commits on Apr 24, 2024

• update comments, change functions order, emit additional event when burn shares

  kovalgek

  committed
  792071c

  Copy full SHA for 792071c

• add integration tests for zero and 1wei amount of token

  kovalgek

  committed
  695fa42

  Copy full SHA for 695fa42

Commits on Apr 29, 2024

• fix critical: mint wstETH and wrap to stETH during stETH deposit and unwrap stETH to wstETH and burn during stETH withdrawal

  kovalgek

  committed
  689a194

  Copy full SHA for 689a194

• update tests for wrap/unwrap on L2 during deposit/withdrwal

  kovalgek

  committed
  737f969

  Copy full SHA for 737f969

• refactor and add new integration tests for non rebasable token

  kovalgek

  committed
  ad309de

  Copy full SHA for ad309de

Commits on May 1, 2024

• refactor _mintTokens, add new method for rebasable token that can unwrap tokens by bridge only, use it in _burnTokens

  kovalgek

  committed
  e4d45cc

  Copy full SHA for e4d45cc

• remove approval before withdrawal in tests, add new tests for bridgeUnwrap method

  kovalgek

  committed
  ccb3410

  Copy full SHA for ccb3410

• remove bridgeMintShares and bridgeBurnShares methods and rename interface

  kovalgek

  committed
  b552925

  Copy full SHA for b552925

• remove tests for bridgeBurnShares and bridgeMintShares

  kovalgek

  committed
  88cf382

  Copy full SHA for 88cf382

Commits on May 2, 2024

• add bridgeWrap, setup infinite allowance l2 bridge for bridged token, refactor finalize deposit

  kovalgek

  committed
  d49322a

  Copy full SHA for d49322a

• add tests for bridgeWrap

  kovalgek

  committed
  e965a88

  Copy full SHA for e965a88

• rename interface

  kovalgek

  committed
  a3abe91

  Copy full SHA for a3abe91

• fix comments in few contracts

  kovalgek

  committed
  d2bc0a1

  Copy full SHA for d2bc0a1

• Merge pull request #10 from lidofinance/feature/rebasable_token_fix_wrapped_balance

  Show description for 9d6f66c
  kovalgek

  authored
  9d6f66c

  Copy full SHA for 9d6f66c

Commits on May 8, 2024

• add unwrapShares method to rebasable roken, add tests

  kovalgek

  committed
  205cd67

  Copy full SHA for 205cd67

• check name and symbol for emptyness during initialization, tests

  kovalgek

  committed
  b68c9a5

  Copy full SHA for b68c9a5

• add comment for CEXes

  kovalgek

  committed
  752bb46

  Copy full SHA for 752bb46

• check maxAllowedTokenRateDeviationPerDay in oracle

  kovalgek

  committed
  f00015b

  Copy full SHA for f00015b

Commits on May 9, 2024

• optimisations: skip token rate range if value the same, improve removing observers, save to constant token rate oracle decimals in token

  kovalgek

  committed
  af27454

  Copy full SHA for af27454

• small improvements: unnecessary spaces, add comments, remove unused functions

  kovalgek

  committed
  ccaa023

  Copy full SHA for ccaa023

• setup token rate oracle decimals in rebasable token constructor

  kovalgek

  committed
  6795332

  Copy full SHA for 6795332

• upgrade comment

  kovalgek

  committed
  560a382

  Copy full SHA for 560a382

• check if bridge is zero address

  kovalgek

  committed
  47c729d

  Copy full SHA for 47c729d

Commits on May 10, 2024

• check time and rate in init, fix rate deviation calculation, tests

  kovalgek

  committed
  a5a3da5

  Copy full SHA for a5a3da5

• change rate and time restrictions during init

  kovalgek

  committed
  eba565f

  Copy full SHA for eba565f

Commits on May 11, 2024

• additional test to prove that it is imposible to init afer upgrade

  kovalgek

  committed
  2f895fa

  Copy full SHA for 2f895fa

• check that withdrawTo doesn't allow to withdraw to stETH on L1 address

  kovalgek

  committed
  be90d6b

  Copy full SHA for be90d6b

Commits on May 12, 2024

• remove bottom limit of l2 blocktime in oracle init

  kovalgek

  committed
  b497031

  Copy full SHA for b497031

Commits on May 15, 2024

• fix comments, error names, refactor token rate oracle and l2bridge

  kovalgek

  committed
  4b301e8

  Copy full SHA for 4b301e8

• remove token rate from event about wrong l1 time

  kovalgek

  committed
  d48ce20

  Copy full SHA for d48ce20

Commits on May 16, 2024

• update comment

  kovalgek

  committed
  5c48830

  Copy full SHA for 5c48830

• use min/max functions

  kovalgek

  committed
  34ac185

  Copy full SHA for 34ac185

• don't allow to call initialize on prev deployed contract

  kovalgek

  committed
  64c8b98

  Copy full SHA for 64c8b98

• draft: change rate reporting approach

  TheDZhon

  committed
  c95fdad

  Copy full SHA for c95fdad

• Merge branch 'feature/rebasable_token_mixbytes_audit_fixes' into draft/change-rate-reporting

  kovalgek

  committed
  d4a19da

  Copy full SHA for d4a19da

Commits on May 20, 2024

• split l1 bridge and token pusher connection to be able to deploy oracle part independently

  kovalgek

  committed
  7019875

  Copy full SHA for 7019875

• fix tests

  kovalgek

  committed
  c2d3650

  Copy full SHA for c2d3650

• refactor scripts

  kovalgek

  committed
  e55068e

  Copy full SHA for e55068e

Commits on May 22, 2024

• add tests for large amount of tokens

  kovalgek

  committed
  a9e4df1

  Copy full SHA for a9e4df1

• add logs to scipts

  kovalgek

  committed
  6c5f357

  Copy full SHA for 6c5f357

• emit correct amount of token during unwrap and bridgeUnwrap

  kovalgek

  committed
  e6888cc

  Copy full SHA for e6888cc

• emit correct events, fix comment, remove unsued code

  kovalgek

  committed
  5ea0159

  Copy full SHA for 5ea0159

• fix: change event name for rate timestamp update

  TheDZhon

  committed
  e137a55

  Copy full SHA for e137a55

• Merge pull request #12 from lidofinance/draft/change-rate-reporting

  Show description for 2830a6d
  TheDZhon

  authored
  2830a6d

  Copy full SHA for 2830a6d

Commits on May 23, 2024

• additional checks in constructors

  kovalgek

  committed
  7369c2e

  Copy full SHA for 7369c2e

• Merge branch 'feature/rebasable_token_mixbytes_audit_fixes' into feature/ackee_fixes

  kovalgek

  committed
  6d653c6

  Copy full SHA for 6d653c6

• add new permit method with signature

  kovalgek

  committed
  e2ec2b4

  Copy full SHA for e2ec2b4

Commits on May 24, 2024

• Merge pull request #13 from lidofinance/feature/ackee_fixes

  Show description for d69127f
  TheDZhon

  authored
  d69127f

  Copy full SHA for d69127f

Commits on May 27, 2024

• remove unused library

  kovalgek

  committed
  8958868

  Copy full SHA for 8958868

• revert approve event changes

  kovalgek

  committed
  5022c96

  Copy full SHA for 5022c96

• draft

  kovalgek

  committed
  074dee0

  Copy full SHA for 074dee0

• update pause/unpause logic

  kovalgek

  committed
  5ce9749

  Copy full SHA for 5ce9749

Commits on May 28, 2024

• update comments, add external methods

  kovalgek

  committed
  6ddbdb5

  Copy full SHA for 6ddbdb5

• add additional checks

  kovalgek

  committed
  ee950e4

  Copy full SHA for ee950e4

• fix tests

  kovalgek

  committed
  c4c14f1

  Copy full SHA for c4c14f1

• return instead of revert when updates are paused

  kovalgek

  committed
  48f3106

  Copy full SHA for 48f3106

Commits on May 29, 2024

• add tests, small improvements in pause

  kovalgek

  committed
  5bc7a43

  Copy full SHA for 5bc7a43

Commits on May 30, 2024

• rename constants, add comments, don't allow often rate updates

  kovalgek

  committed
  e54f586

  Copy full SHA for e54f586

• add tests for double pause/unpause

  kovalgek

  committed
  a1f2587

  Copy full SHA for a1f2587

Commits on May 31, 2024

• Merge pull request #14 from lidofinance/feature/pause_token_rate

  Show description for be9775f
  kovalgek

  authored
  be9775f

  Copy full SHA for be9775f

• fix comments, small refactoring, rename events, constants

  kovalgek

  committed
  b68fbaf

  Copy full SHA for b68fbaf

• Merge pull request #11 from lidofinance/feature/rebasable_token_mixbytes_audit_fixes

  Show description for a479315
  kovalgek

  authored
  a479315

  Copy full SHA for a479315

Commits on Jun 6, 2024

• check admin address during initialization in bridges, fix indentation, tests

  kovalgek

  committed
  6fba907

  Copy full SHA for 6fba907

• Merge pull request #15 from lidofinance/feature/ackee_fixes_1_1

  Show description for a31049a
  kovalgek

  authored
  a31049a

  Copy full SHA for a31049a

Commits on Jun 11, 2024

• update upgrade/deploy scripts

  kovalgek

  committed
  baf9859

  Copy full SHA for baf9859

Commits on Jun 14, 2024

• add permission to handle toekn rate report by token rate notifier

  kovalgek

  committed
  12333ef

  Copy full SHA for 12333ef