add support for spc link / urls in spc indirect data #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As demonstrated by @lebr0nli in the sample `ELF/issue_dynamic_table.elf`, the PT_DYNAMIC segment can have an "invalid" offset while still running correctly. This commit changes the logic of the dynamic table processing by using the PT_LOAD segment that wraps this table
|
Interesting use case :) Would you mind sharing a sample of a font using this PKCS #9 signature? |
|
@romainthomas due to legal rights I am not able to do that |
|
@romainthomas LIEF::logging::set_level(LIEF::logging::LEVEL::DEBUG); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@romainthomas
My use case of LIEF is reading signatures and validating them.
This is not necessarily using executables, instead I am validating fonts.
The Spc Indirect Data can contain other values instead of files, also urls.
This PR adresses the issue to support urls too.
If possible please review and merge, as I would really like to continue using this lib.
There is no real support for PKCS#9 for python out there ...
Thanks
Bernd