Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPD-46233 wip #6169

Closed
wants to merge 5 commits into from
Closed

LPD-46233 wip #6169

wants to merge 5 commits into from

Conversation

andrea-ale-sbarra
Copy link
Member

@andrea-ale-sbarra andrea-ale-sbarra force-pushed the LPD-46233 branch 3 times, most recently from 0d2adf8 to 4fb6d05 Compare January 23, 2025 16:48
@andrea-ale-sbarra
LPD-46233 decide if specification is facetable
58b99e3 
# breaking

## What modules/apps/commerce/commerce-product-test-util/src/main/java/com/liferay/commerce/product/test/util/CPTestUtil.java

modules/apps/commerce/commerce-product-test-util/src/main/java/com/liferay/commerce/product/test/util/CPTestUtil.java method addCPSpecificationOption now has a new parameter to configure if the specfication is facetable

## Why

this change is required to make tests more configurable

----
@andrea-ale-sbarra
LPD-46233 adapt usage
1158389
@andrea-ale-sbarra
LPD-46233 test
2f854fc
@andrea-ale-sbarra
LPD-46233 semantic versioning (gw baseLine)
794353a
@andrea-ale-sbarra andrea-ale-sbarra marked this pull request as ready for review January 24, 2025 09:13
@andrea-ale-sbarra
Copy link
Member Author

ci:test:sf

@andrea-ale-sbarra
Copy link
Member Author

ci:stop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrea-ale-sbarra