-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update solc and evm version #981
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes update the Solidity compiler and EVM versions in the main configuration (foundry.toml), shifting from version 0.8.17 to 0.8.22 and from “shanghai” to “cancun” respectively. In addition, multiple test files have been modified to change the Solidity pragma declaration from a fixed version ("0.8.17") to a caret requirement ("^0.8.17"), broadening compatibility. No modifications were made to the public or exported entities in any file. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (5)
⏰ Context from checks skipped due to timeout of 90000ms (4)
🔇 Additional comments (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Which Jira task belongs to this PR?
Why did I implement it this way?
We used to have typescript and other compatibility issues when running our codebase on higher solidity version but that seems to have changed now. Our auditor (Sujith) has confirmed that changing to newer solc and evm version does not impose a security risk.
Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)