Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discord release notification #1427

Merged

Conversation

guarin
Copy link
Contributor

@guarin guarin commented Nov 15, 2023

Changes

  • Automatically send message to discord for new releases

The message will look like this and be sent to the general channel:
Screen Shot 2023-11-15 at 10 12 23

I tried to keep the action simple and did not add any fancy checks. In some weird scenarios we might get additional or no messages:

  • If a release is first released as a pre-release and only later changed to a latest release no notification will be sent
  • If a release is released but not marked as the latest release a notification will still be sent

Note that no message will be sent for draft releases, edits, deleted releases, etc.

How was it tested?

Tested it in a test repo and test discord channel.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5ef7d0) 85.34% compared to head (fea9263) 85.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1427   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files         130      130           
  Lines        5488     5488           
=======================================
  Hits         4684     4684           
  Misses        804      804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@philippmwirth philippmwirth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@guarin guarin merged commit 9f2ed93 into master Nov 15, 2023
10 checks passed
@guarin guarin deleted the guarin-lig-4085-send-message-to-discord-for-new-pip-releases branch November 15, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants