-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DetConSLoss and DetConBLoss #1771
Conversation
Co-authored-by: guarin <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1771 +/- ##
==========================================
+ Coverage 85.08% 85.25% +0.16%
==========================================
Files 162 163 +1
Lines 6747 6834 +87
==========================================
+ Hits 5741 5826 +85
- Misses 1006 1008 +2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: guarin <[email protected]>
Tests have been completely re-written.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments but overall looks very good! Let's get this merged :)
Co-authored-by: guarin <[email protected]>
…i/lightly into lionel-lig-5628-add-detconloss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
DetConBLoss
for Detcon with BYOL andDetConSLoss
for Detcon with SimCLRlightly.loss.DetConBLoss
andlightly.loss.DetConSLoss
How has it been tested?
Attachments