Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix torchvision dependency test #1779

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

liopeer
Copy link
Contributor

@liopeer liopeer commented Jan 10, 2025

Changes

  • changes how we test if the torchvision.transforms.v2 is available

Necessity

  • Testing if we can import torchvision.transforms.v2 is not enough since we need to make sure that we install a version that also has a stable version of the API. Trying to mport Mask should be safer.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.24%. Comparing base (c25309c) to head (37ebd7c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1779   +/-   ##
=======================================
  Coverage   85.24%   85.24%           
=======================================
  Files         163      163           
  Lines        6832     6832           
=======================================
  Hits         5824     5824           
  Misses       1008     1008           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lightly/utils/dependency.py Outdated Show resolved Hide resolved
@liopeer liopeer merged commit 5db25cf into master Jan 13, 2025
14 checks passed
@liopeer liopeer deleted the fix-torchvisionv2-dependency branch January 13, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants