Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue that caused animations not to finish all the way #113

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Fix issue that caused animations not to finish all the way #113

merged 1 commit into from
Dec 20, 2023

Conversation

frank-weindel
Copy link
Collaborator

This fixes the reported issue where animations do not always progress all the way to their destination before stopping.

michielvandergeest
michielvandergeest approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@michielvandergeest michielvandergeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Blits transitions example and this seems to fix the issue I experience earlier. Transitions now finish correctly with their final value.

@frank-weindel frank-weindel added the bug Something isn't working label Dec 20, 2023
@frank-weindel frank-weindel added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit 4221d17 Dec 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michielvandergeest michielvandergeest michielvandergeest approved these changes

@wouterlucas wouterlucas Awaiting requested review from wouterlucas

@chiefcll chiefcll Awaiting requested review from chiefcll

@Drulokia Drulokia Awaiting requested review from Drulokia

@jfboeve jfboeve Awaiting requested review from jfboeve

@erikhaandrikman erikhaandrikman Awaiting requested review from erikhaandrikman

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frank-weindel @michielvandergeest