Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Texture Throttling loading #519

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Optimize Texture Throttling loading #519

merged 4 commits into from
Feb 12, 2025

Conversation

wouterlucas
Copy link
Contributor

@wouterlucas wouterlucas commented Feb 10, 2025 •
edited
Loading

This PR addresses the following issues:

  • Textures being deleted while actively being in queue for Texture throttling --> Fixed by yanking them from the queue if orphaned
  • Textures data being deleted while texture was being uploaded --> moved texture data deletion to the coreCtx handling so it is all in 1 place
  • Textures being procssed for download while having no download aspect, this should mostly be for ImageTextures only --> Color, Sub, and RTT textures are directly pushed to the upload queue respectively
  • Cleaned up excessive handling in the subTexture

Added new test cases to reflect their real world-ish use cases.

There is an ongoing issue with RTT and memory as outlined #518 - will push this out and investigate that separately.

michielvandergeest
michielvandergeest approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@michielvandergeest michielvandergeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

1 suggestion for a nano optimization 😄

src/core/CoreTextureManager.ts Outdated
Comment on lines 482 to 483
this.downloadTextureSourceQueue.includes(texture) ||
this.uploadTextureQueue.includes(texture)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be changed to a strict true check instead of a truthy check

@jfboeve jfboeve added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 8d2d3a9 Feb 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfboeve jfboeve jfboeve approved these changes

@michielvandergeest michielvandergeest michielvandergeest approved these changes

@erikhaandrikman erikhaandrikman Awaiting requested review from erikhaandrikman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wouterlucas @jfboeve @michielvandergeest