-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update main
post-0.1 release
#3546
Update main
post-0.1 release
#3546
Conversation
25ff653
to
c144d42
Compare
Can we make the version numbers, like, 0.0.1 or something so we don't have to change them until we branch? Alternatively, they should be 0.2-git or so. |
Not quite sure I'm following - why would we need to change them? Ah, do you mean so that we don't need to keep them in sync with the patch releases? |
Just so we don't have to update the version numbers on |
beeed1e
to
c144d42
Compare
Well, we could also treat PRs updating the README and bumping version numbers just as any other PRs: first land them on
I kinda dislike the former as a
|
Not really - we might want to do an 0.1.2 and 0.2.1 at the same time and any such commits will just conflict and be more work than they're worth...
Weird, the docs say explicitly you can do this... https://doc.rust-lang.org/cargo/reference/manifest.html#the-version-field Can we do 0.2git without the -? |
Note that it says
Nope. |
4b9b088
to
ab81966
Compare
Now included a fixup going this way. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3546 +/- ##
==========================================
+ Coverage 88.42% 88.92% +0.49%
==========================================
Files 149 149
Lines 113302 116639 +3337
Branches 113302 116639 +3337
==========================================
+ Hits 100191 103725 +3534
+ Misses 10636 10522 -114
+ Partials 2475 2392 -83 ☔ View full report in Codecov by Sentry. |
I don't think |
Hmm, I kind of see your point. What's your suggestion then? IMO, any variant of We could also bump the MSRV to 1.75 for the whole workspace, as, IIUC, it would allow us to drop the |
I guess if we have to have a version my preference would be 0.2+git or 0.2-prealpha1
Ha, that would be nice. |
ab81966
to
dc8160d
Compare
Alright, now updated all to use the next, not the current version with the |
dc8160d
to
bab4abb
Compare
We bump the version number on `main` to the next-planned minor release (mod `+git` metadata tag). This aligns what we're planning to do in LDK (see lightningdevkit/rust-lightning#3546) and allows us to run SemVer checks on PRs towards `main`.
LGTM, feel free to squash. |
bab4abb
to
a116495
Compare
Squashed fixups without further changes. |
a116495
to
3c55cf7
Compare
Sadly, dns-resolver got uploaded as 0.1.0 without a -beta1 tag (and yanked), and thus we release it here as 0.2.0.
.. we planned to use the BP for some more advanced integration tests, but we haven't actually implemented them as of now. Here we drop the unnecessary dev-dependency for now.
3c55cf7
to
f19016f
Compare
Rebased on current main, as I had to rebase #3509 on top of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
Here, we cherry-pick the commits updating README and version numbers from the
0.1
branch, as it's otherwise a bit confusing to not have them up-to-date (especially sincemain
acts effectively as the landing page of the repository).