Split commitment_signed handling by check-accept
#3633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
force-pushed
the
2025-02-split-commitment-signed
branch
from
d8bdc8f to
3a52856
Compare
wpaulino
reviewed
Feb 28, 2025
jkczyz
force-pushed
the
2025-02-split-commitment-signed
branch
from
9c29928 to
5d9e8f1
Compare
|
Latest pushes were just to address |
jkczyz
force-pushed
the
2025-02-split-commitment-signed
branch
from
5d9e8f1 to
08cef17
Compare
Yeah, luckily compiling after removing the |
jkczyz
force-pushed
the
2025-02-split-commitment-signed
branch
from
08cef17 to
baa9e76
Compare
|
Feel free to squash |
When handling commitment_signed messages, a number of checks are performed before a ChannelMonitorUpdate is created and returned. Once splicing is added, these checks need to be performed on the primary FundingScope and any pending scopes that resulted from splicing or RBF. This commit splits the handling into a check and accept methods, taking &self and &mut self, respectively. This ensures that the ChannelContext is not modified between checks. Once all funding scopes have been checked successfully, the accept portion of the code can then execute.
Now that commitment_signed is split into check and accept methods, move the check portion from FundedChannel to ChannelContext. This allows calling it with a different FundingScope when there are pending splices and RBF attempts.
jkczyz
force-pushed
the
2025-02-split-commitment-signed
branch
from
baa9e76 to
119b64a
Compare
|
Squashed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3633 +/- ##
==========================================
- Coverage 89.19% 89.19% -0.01%
==========================================
Files 152 152
Lines 118681 118696 +15
Branches 118681 118696 +15
==========================================
+ Hits 105860 105869 +9
- Misses 10236 10242 +6
Partials 2585 2585 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling
commitment_signed messages, a number of checks are performed before aChannelMonitorUpdateis created and returned. Once splicing is added, these checks need to be performed on the primaryFundingScopeand any pending scopes that resulted from splicing or RBF.This PR splits the handling into a check and accept methods, taking
&selfand&mut self, respectively. This ensures that theChannelContextis not modified between checks. Once all funding scopes have been checked successfully, the accept portion of the code can then execute.