Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql-5] accounts: use clock.Clock #944

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

ellemouton
Copy link
Member

In this commit, we use the clock.Clock type instead of directly calling time.Now().
This is in preparation for cleaner testing against different SQL backends later on in the series.

@ellemouton ellemouton added no-changelog This PR is does not require a release notes entry sql-ize labels Jan 21, 2025
@ellemouton ellemouton self-assigned this Jan 21, 2025
Copy link
Contributor

@bitromortac bitromortac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 this comment could be addressed here #941 (comment)

Copy link
Contributor

@ViktorTigerstrom ViktorTigerstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

In this commit, we use the clock.Clock type instead of directly calling
time.Now().
@ellemouton ellemouton merged commit 2724161 into lightninglabs:master Jan 23, 2025
13 checks passed
@ellemouton ellemouton deleted the sql5Accounts5 branch January 23, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog This PR is does not require a release notes entry sql-ize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants