GitHub+accounts: fix i386 compilation issue #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to control the cache key and whether we want to cache the Go build cache (which can grow very large).
guggero
force-pushed
the
compilation-fix
branch
from
ebc1aaf to
d63e07c
Compare
Apparently the %d formatting directive implicitly uses `int` as its data type, which on i386 systems is int32. So the value math.MaxInt64 overflows that value, which causes the compilation to fail.
guggero
force-pushed
the
compilation-fix
branch
from
d63e07c to
1657584
Compare
This attempts to fix the following error that sometimes occurs on the GitHub runners: go: github.com/lightninglabs/lightning-terminal imports github.com/lightningnetwork/lnd/kvdb imports github.com/lightningnetwork/lnd/kvdb/etcd imports go.etcd.io/etcd/server/v3/embed: mkdir /home/runner/go/pkg/mod/cache/download/go.etcd.io/etcd/server: permission denied The suspicion is that the lint step that runs as root within docker changes the permissions of some of the module cache directories. So by simply changing the order of operations, this should be fixed.
This takes over two more settings we have in the lnd repo. The first is to cancel existing CI runs for the same PR if it is pushed again before the previous run has completed. The second is just for consistency, to make sure all shells are bash shells.
ellemouton
approved these changes
Jan 23, 2025
Comment on lines
+247
to
+248
| return fmt.Errorf("amount %v exceeds the maximum of %v", | ||
| amount, int64(math.MaxInt64)) |
| @@ -207,7 +207,7 @@ jobs: | |||
| run: mkdir -p app/build; touch app/build/index.html | |||
|
|
|||
| - name: run check | |||
| run: make lint mod-check | |||
| run: make mod-check && make lint | |||
There was a problem hiding this comment.
great investigation skills 🏅
| @@ -8,6 +8,15 @@ on: | |||
| branches: | |||
| - "*" | |||
|
|
|||
| concurrency: | |||
| # Cancel any previous workflows if they are from a PR or push. | |||
There was a problem hiding this comment.
Indeed, very nice 🚀!
ViktorTigerstrom
approved these changes
Jan 23, 2025
| @@ -8,6 +8,15 @@ on: | |||
| branches: | |||
| - "*" | |||
|
|
|||
| concurrency: | |||
| # Cancel any previous workflows if they are from a PR or push. | |||
There was a problem hiding this comment.
Indeed, very nice 🚀!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a compilation issue that prevented the release build.
And in the process also updates and fixes a couple of things in the CI pipeline:
actions/checkoutto the latest version