Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not delete persisted credentials when memoryOnly is used #106

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

itsrachelfish
Copy link
Contributor

Persisted credentials should only be removed when localstorage is being wiped.

Fixes bug in terminal when multiple nodes are used simultaneously.

Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 👌

@jamaljsr jamaljsr merged commit b7dce83 into main Feb 12, 2024
3 checks passed
@jamaljsr jamaljsr deleted the fix-persisted-credentials branch February 12, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants