Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapchannel: add new IsCustomHTLC method to aux traffic shaper #1334

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

Roasbeef
Copy link
Member

This lets other sub-systems determine if an HTLC is for a custom channel, without needing to know about the precise record types.

This lets other sub-systems determine if an HTLC is for a custom
channel, without needing to know about the precise record types.
@Roasbeef Roasbeef added this to the v0.5.1 milestone Jan 28, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13001912377

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 29 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.009%) to 40.705%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tapchannel/aux_traffic_shaper.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
tappsbt/create.go 2 53.22%
fn/option.go 3 43.3%
tapgarden/caretaker.go 4 68.11%
asset/asset.go 4 76.82%
asset/mock.go 6 91.98%
universe/interface.go 10 52.81%
Totals Coverage Status
Change from base Build 13001676154: -0.009%
Covered Lines: 26748
Relevant Lines: 65712

💛 - Coveralls

Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@GeorgeTsagk GeorgeTsagk added this pull request to the merge queue Jan 28, 2025
Merged via the queue into lightninglabs:main with commit a445de0 Jan 28, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants