Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GroupKey unit tests. #1350

Merged
merged 7 commits into from
Feb 7, 2025
Merged

Refactor GroupKey unit tests. #1350

merged 7 commits into from
Feb 7, 2025

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Feb 4, 2025

  • Moved group key-related unit tests to asset/group_key_test.go.
  • Improved test naming to distinguish between V0 and V1 cases clearly.

ffranr added 7 commits February 4, 2025 12:19
@ffranr
asset: rename unit test file to group_key_test.go
ff293be 
Renamed `group_key_reveal_test.go` to `group_key_test.go` to reflect a
more general scope.
@ffranr
asset: move unit test TestGroupKeyIsEqual to group_key_test.go
cf6f8de
@ffranr
asset: move unit test TestAssetGroupKey to group_key_test.go
57e06d3
@ffranr
asset: rename unit test TestAssetGroupKey to TestDeriveGroupKeyV0
3b9c403 
Clarify that the test applies specifically to the group key V0.
@ffranr
asset: move unit test TestDeriveGroupKey to group_key_test.go
5bc4bdb
@ffranr
asset: rename unit test TestDeriveGroupKey for clarity
a51eb22 
Rename `TestDeriveGroupKey` to `TestGroupKeyDerivationInvalidAsset` to
clarify that the test pertains to invalid assets and the inability to
derive group keys from/for them.
@ffranr
asset: improve doc
44f43a6
@ffranr ffranr self-assigned this Feb 4, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13135877926

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 40.74%
Files with Coverage Reduction New Missed Lines %
tapchannel/aux_leaf_signer.go 2 43.08%
tapgarden/caretaker.go 4 68.11%
tapchannel/aux_invoice_manager.go 5 83.13%
Totals Coverage Status
Change from base Build 13127541505: 0.01%
Covered Lines: 26777
Relevant Lines: 65726
💛 - Coveralls

GeorgeTsagk
GeorgeTsagk approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean-up! 🧹

@ffranr ffranr requested review from guggero and removed request for gijswijs February 7, 2025 12:44
@guggero guggero merged commit 303f3da into main Feb 7, 2025
18 checks passed
@guggero guggero deleted the mv-groupkey-unit-tests branch February 7, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guggero guggero guggero approved these changes

@GeorgeTsagk GeorgeTsagk GeorgeTsagk approved these changes

Assignees

@ffranr ffranr

Labels
group_key unit-test
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ffranr @coveralls @guggero @GeorgeTsagk