On MacOS, tests hangs. #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems that you can't cancel on MacOS: https://github.com/lightpanda-io/tigerbeetle-io/blob/main/io/darwin.zig#L580
src/loop.zig
Outdated
| @@ -291,4 +291,11 @@ pub const SingleThreaded = struct { | |||
| report("recv done, remaining events: {d}", .{old_events_nb - 1}); | |||
| } | |||
| } | |||
|
|
|||
| pub fn canCancel() bool { | |||
There was a problem hiding this comment.
I'm not sure about adding a function into the API only for test purpose.
What about running the cancel test only under linux for now?
|
Indeed cancel is implemented only for IO_Uring,.. I didn't notice the test would hangs on macos. This is an argument to move to https://github.com/mitchellh/libxev in the future. |
Rename canCancel to isCancelAvailable which seems more descriptive.
krichprollsch
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that you can't cancel on MacOS:
https://github.com/lightpanda-io/tigerbeetle-io/blob/main/io/darwin.zig#L580