Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to sample remote signer #100

Merged
merged 3 commits into from
May 2, 2024
Merged

Add validation to sample remote signer #100

merged 3 commits into from
May 2, 2024

Conversation

zhenlu
Copy link
Contributor

@zhenlu zhenlu commented Apr 29, 2024 •
edited
Loading

Fixes LIG-5378

@zhenlu zhenlu requested a review from alecchendev May 1, 2024 21:11
@zhenlu
Copy link
Contributor Author

zhenlu commented May 1, 2024

@alecchendev I can merge this right? I think you have landed your change.

alecchendev
alecchendev approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@alecchendev alecchendev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - used this to try out my changes piping more data for closing signed

@zhenlu zhenlu merged commit 0760bd0 into main May 2, 2024
1 check passed
@zhenlu zhenlu deleted the validation branch May 2, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecchendev alecchendev alecchendev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhenlu @alecchendev