Added offer mutations to LightsparkClient.
#159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mhrheaume
commented
Jan 28, 2025
mhrheaume
commented
- CreateOffer for creating a new offer with the specified parameters.
- PayOffer for paying an offer.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
scripts/create_offer.go
Outdated
| import "github.com/lightsparkdev/go-sdk/objects" | ||
|
|
||
| const CREATE_OFFER_MUTATION = ` | ||
| mutation CreateInvoice( |
There was a problem hiding this comment.
The mutation name CreateInvoice should be CreateOffer to accurately reflect that this mutation creates an offer, not an invoice. This ensures consistency between the operation name and its functionality.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
- CreateOffer for creating a new offer with the specified parameters. - PayOffer for paying an offer.
mhrheaume
force-pushed
the
mhr/offer_mutations
branch
from
47aade1 to
06a1204
Compare
zhenlu
approved these changes
Jan 28, 2025
| var offer objects.Offer | ||
| offerJson, err := json.Marshal(output["offer"].(map[string]interface{})) | ||
| if err != nil { | ||
| return nil, errors.New(("error parsing offer")) |
There was a problem hiding this comment.
There are redundant parentheses in errors.New(("error parsing offer")). The correct syntax is errors.New("error parsing offer").
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.