Add an option to let go remote signer respond directly through webhooks. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mhrheaume
reviewed
Mar 22, 2024
| if webhook.EventType != objects.WebhookEventTypeRemoteSigning { | ||
| return "", errors.New("webhook event is not for remote signing") |
There was a problem hiding this comment.
Do we need validator.ShouldSign in this method?
There was a problem hiding this comment.
TBH I don't think this validator interface is needed at all. But I'll add it here as well for consistence purpose.
zhenlu
force-pushed
the
03-22-Add_an_option_to_let_go_remote_signer_respond_directly_through_webhooks
branch
from
1074ca1 to
2d72f63
Compare
mhrheaume
approved these changes
Mar 22, 2024
zhenlu
deleted the
03-22-Add_an_option_to_let_go_remote_signer_respond_directly_through_webhooks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.