Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Release.MD #44

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Add Release.MD #44

merged 1 commit into from
Dec 15, 2023

Conversation

zhenlu
Copy link
Contributor

@zhenlu zhenlu commented Dec 15, 2023

No description provided.

Copy link
Contributor Author

zhenlu commented Dec 15, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@zhenlu zhenlu force-pushed the 12-15-Add_Release.MD branch from b201563 to 144b726 Compare December 15, 2023 20:54
@zhenlu zhenlu requested a review from jklein24 December 15, 2023 20:54
Run the following command to publish the go library.

```bash
$ GOPROXY=proxy.golang.org go list -m github.com/lightsparkdev/lightspark-crypto-uniffi/lightspark-crypto-go@[version]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw, I actually don't think this command is necessary every time, it just forces the cache to be cleared quicker. @mhrheaume would know better than I do though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that too but the official docs don't really make it super clear: https://go.dev/doc/modules/publishing . Guess it doesn't hurt, though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually encountered an error this time when I tried go get before I did go list. It says the version cannot be found.

Copy link
Contributor Author

zhenlu commented Dec 15, 2023

Merge activity

  • Dec 15, 4:47 PM: Graphite rebased this pull request as part of a merge.
  • Dec 15, 4:48 PM: Graphite couldn't merge this PR because it was not satisfying all requirements.

@zhenlu zhenlu force-pushed the 12-15-Add_Release.MD branch 2 times, most recently from 3c63bc0 to 990cf93 Compare December 15, 2023 21:50
@zhenlu zhenlu force-pushed the 12-15-Add_Release.MD branch from 990cf93 to 6d750b3 Compare December 15, 2023 21:51
@zhenlu zhenlu merged commit b63d70f into main Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants