Skip to content

Commit

Permalink
tests: Remove unneeded fixture
Browse files Browse the repository at this point in the history
We now have a make action to run the tests that ensures that config values that would be overridden by our local env vars are set to the test values before running the tests, including ckan.site_url.
  • Loading branch information
bellisk committed Nov 6, 2024
1 parent c960b58 commit 66ad435
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions ckanext/switzerland/tests/test_sbb_harvester.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ def test_updated_file_before_last_harvester_run(self):
self.assertEqual(dataset["resources"][0]["identifier"], "Didok.csv")

@pytest.mark.usefixtures("with_plugins", "clean_db", "clean_index")
@pytest.mark.ckan_config("ckan.site_url", "http://odp.test")
def test_update_version(self):
filesystem = self.get_filesystem(filename="20160901.csv")
MockFTPStorageAdapter.filesystem = filesystem
Expand Down Expand Up @@ -230,7 +229,6 @@ def test_update_version(self):
self.assert_resource_data(package.resources[1].id, data.dataset_content_1)

@pytest.mark.usefixtures("with_plugins", "clean_db", "clean_index")
@pytest.mark.ckan_config("ckan.site_url", "http://odp.test")
def test_update_file_of_old_version(self):
"""
initial state:
Expand Down Expand Up @@ -279,7 +277,6 @@ def test_update_file_of_old_version(self):
self.assert_resource_data(package.resources[1].id, data.dataset_content_3)

@pytest.mark.usefixtures("with_plugins", "clean_db", "clean_index")
@pytest.mark.ckan_config("ckan.site_url", "http://odp.test")
def test_update_file_of_newest_version(self):
"""
initial state:
Expand Down Expand Up @@ -326,7 +323,6 @@ def test_update_file_of_newest_version(self):
self.assert_resource_data(package.resources[1].id, data.dataset_content_1)

@pytest.mark.usefixtures("with_plugins", "clean_db", "clean_index")
@pytest.mark.ckan_config("ckan.site_url", "http://odp.test")
def test_order_permalink_regex(self):
filesystem = self.get_filesystem(filename="20160901.csv")
MockFTPStorageAdapter.filesystem = filesystem
Expand Down

0 comments on commit 66ad435

Please sign in to comment.