removed unnecessary usage of nsstring

internal/objc/objc.go

@@ -57,16 +57,6 @@ const char *getUUID()
 	NSString *uuid = [[NSUUID UUID] UUIDString];
 	return [uuid UTF8String];
 }
-
-const char *CStringFromNSString(void *ptr)
-{
-    return [(NSString *)ptr UTF8String];
-}
-
-int LengthFromNSString(void *ptr)
-{
-    return [(NSString *)ptr length];
-}
 */
 import "C"
 import (
@@ -152,27 +142,6 @@ func (n *NSArray) ToPointerSlice() []unsafe.Pointer {
 	return ret
 }
 
-// NSString indicates NSString
-type NSString struct {
-	*Pointer
-}
-
-// NewNSString creates a new NSString from pointer.
-func NewNSString(p unsafe.Pointer) *NSString {
-	return &NSString{NewPointer(p)}
-}
-
-// CString converts *C.char from *NSString
-func (s *NSString) CString() *C.char {
-	return C.CStringFromNSString(s.ptr())
-}
-
-// String converts Go string from *NSString
-func (s *NSString) String() string {
-	length := C.LengthFromNSString(s.ptr())
-	return C.GoStringN(s.CString(), C.int(length))
-}
-
 // ConvertToNSMutableArray converts to NSMutableArray from NSObject slice in Go world.
 func ConvertToNSMutableArray(s []NSObject) *Pointer {
 	ln := len(s)

network.go

@@ -62,17 +62,13 @@ func (*baseBridgedNetwork) NetworkInterfaces() []BridgedNetwork {
 }
 
 func (b *baseBridgedNetwork) Identifier() string {
-	nsStirng := objc.NewNSString(
-		C.VZBridgedNetworkInterface_identifier(objc.Ptr(b)),
-	)
-	return nsStirng.String()
+	cstring := (*char)(C.VZBridgedNetworkInterface_identifier(objc.Ptr(b)))
+	return cstring.String()
 }
 
 func (b *baseBridgedNetwork) LocalizedDisplayName() string {
-	nsStirng := objc.NewNSString(
-		C.VZBridgedNetworkInterface_localizedDisplayName(objc.Ptr(b)),
-	)
-	return nsStirng.String()
+	cstring := (*char)(C.VZBridgedNetworkInterface_localizedDisplayName(objc.Ptr(b)))
+	return cstring.String()
 }
 
 // Network device attachment using network address translation (NAT) with outside networks.

virtualization_11.h

@@ -65,8 +65,8 @@ void *newVZFileHandleSerialPortAttachment(int readFileDescriptor, int writeFileD
 void *newVZFileSerialPortAttachment(const char *filePath, bool shouldAppend, void **error);
 void *newVZVirtioConsoleDeviceSerialPortConfiguration(void *attachment);
 void *VZBridgedNetworkInterface_networkInterfaces(void);
-void *VZBridgedNetworkInterface_identifier(void *networkInterface);
-void *VZBridgedNetworkInterface_localizedDisplayName(void *networkInterface);
+const char *VZBridgedNetworkInterface_identifier(void *networkInterface);
+const char *VZBridgedNetworkInterface_localizedDisplayName(void *networkInterface);
 void *newVZBridgedNetworkDeviceAttachment(void *networkInterface);
 void *newVZNATNetworkDeviceAttachment(void);
 void *newVZFileHandleNetworkDeviceAttachment(int fileDescriptor);

virtualization_11.m

@@ -415,10 +415,10 @@ void setStorageDevicesVZVirtualMachineConfiguration(void *config,
 /*!
  @abstract Return the unique identifier for this interface. The identifier is the BSD name associated with the interface (e.g. "en0").
  */
-void *VZBridgedNetworkInterface_identifier(void *networkInterface)
+const char *VZBridgedNetworkInterface_identifier(void *networkInterface)
 {
     if (@available(macOS 11, *)) {
-        return [(VZBridgedNetworkInterface *)networkInterface identifier]; // NSString *
+        return [[(VZBridgedNetworkInterface *)networkInterface identifier] UTF8String];
     }
 
     RAISE_UNSUPPORTED_MACOS_EXCEPTION();
@@ -427,10 +427,10 @@ void setStorageDevicesVZVirtualMachineConfiguration(void *config,
 /*!
  @abstract Return a display name if available (e.g. "Ethernet").
  */
-void *VZBridgedNetworkInterface_localizedDisplayName(void *networkInterface)
+const char *VZBridgedNetworkInterface_localizedDisplayName(void *networkInterface)
 {
     if (@available(macOS 11, *)) {
-        return [(VZBridgedNetworkInterface *)networkInterface localizedDisplayName]; // NSString *
+        return [[(VZBridgedNetworkInterface *)networkInterface localizedDisplayName] UTF8String];
     }
 
     RAISE_UNSUPPORTED_MACOS_EXCEPTION();