fix nevermelting ice crystal proc (wowsims#3865)

* fix nevermelting ice crystal proc * improved DP can only proc fetish, not much else * seems like stacks should decrease on most procs (tentative)
lime-green · Oct 11, 2023 · 05ba4cd · 05ba4cd
1 parent c54e867
commit 05ba4cd
Show file tree

Hide file tree

Showing 9 changed files with 346 additions and 346 deletions.
diff --git a/sim/common/wotlk/other_effects.go b/sim/common/wotlk/other_effects.go
@@ -360,7 +360,7 @@ func init() {
 
 		core.ApplyProcTriggerCallback(&character.Unit, activeAura, core.ProcTrigger{
 			Callback: core.CallbackOnSpellHitDealt,
-			ProcMask: core.ProcMaskSpellDamage,
+			ProcMask: core.ProcMaskSpellOrProc | core.ProcMaskWeaponProc | core.ProcMaskSuppressedProc,
 			Outcome:  core.OutcomeCrit,
 			Handler: func(sim *core.Simulation, _ *core.Spell, _ *core.SpellResult) {
 				activeAura.RemoveStack(sim)

diff --git a/sim/paladin/protection/TestProtection.results b/sim/paladin/protection/TestProtection.results
@@ -547,8 +547,8 @@ dps_results: {
 dps_results: {
  key: "TestProtection-AllItems-NevermeltingIceCrystal-50259"
  value: {
-  dps: 3230.88163
-  tps: 7752.35562
+  dps: 3201.46897
+  tps: 7684.70377
  }
 }
 dps_results: {

diff --git a/sim/paladin/retribution/TestRetribution.results b/sim/paladin/retribution/TestRetribution.results
@@ -634,8 +634,8 @@ dps_results: {
 dps_results: {
  key: "TestRetribution-AllItems-NevermeltingIceCrystal-50259"
  value: {
-  dps: 6555.96091
-  tps: 6641.44533
+  dps: 6478.3902
+  tps: 6563.87462
   dtps: 10.29273
  }
 }

diff --git a/sim/priest/devouring_plague.go b/sim/priest/devouring_plague.go
@@ -19,7 +19,7 @@ func (priest *Priest) registerDevouringPlagueSpell() {
 		impDevouringPlague = priest.RegisterSpell(core.SpellConfig{
 			ActionID:    core.ActionID{SpellID: 63675},
 			SpellSchool: core.SpellSchoolShadow,
-			ProcMask:    core.ProcMaskProc, // this can proc things like Talisman of Volatile Power
+			ProcMask:    core.ProcMaskSuppressedProc, // this can proc things like Talisman of Volatile Power
 			Flags:       core.SpellFlagDisease,
 
 			BonusHitRating: float64(priest.Talents.ShadowFocus) * 1 * core.SpellHitRatingPerHitChance,