Skip to content

Commit

Permalink
πŸ› better parse remote client address (#170)
Browse files Browse the repository at this point in the history
* πŸ› fix: better parse remote client address

* πŸ”§ chore: update server listen hostname
  • Loading branch information
rezk2ll authored Jan 23, 2025
1 parent 59f1254 commit fdddc80
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/federated-identity-service/server.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ Promise.all(promises)
app.use(federatedIdentityService.routes)
const port = process.argv[2] != null ? parseInt(process.argv[2]) : 3000
console.log(`Listening on port ${port}`)
app.listen(port)
app.listen(port, '0.0.0.0')
})
.catch((e) => {
console.error(e)
Expand Down
7 changes: 6 additions & 1 deletion packages/federated-identity-service/src/middlewares/auth.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,16 @@ export const Authenticate = (
const tokenRe = /^Bearer (\S+)$/
return (req, res, callbackMethod) => {
const request = req as AuthRequest
const originalRequesterIPAddress = trustXForwardedForHeader
const remoteAddress = trustXForwardedForHeader
? // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions
(request.headers['x-forwarded-for'] as string) ||
(request.socket.remoteAddress as string)
: (request.socket.remoteAddress as string)

const parsedAdressArray = remoteAddress.split(':')
const originalRequesterIPAddress =
parsedAdressArray[parsedAdressArray.length - 1]

logger.info('', {
ip: originalRequesterIPAddress,
httpMethod: request.method,
Expand Down
2 changes: 1 addition & 1 deletion server.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ if (process.argv[2] === 'generate') {

const port = process.argv[2] != null ? parseInt(process.argv[2]) : 3000
console.log(`Listening on port ${port}`)
app.listen(port)
app.listen(port, '0.0.0.0')
})
.catch((e) => {
console.error(e)
Expand Down

0 comments on commit fdddc80

Please sign in to comment.