Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed download not working from mySpace and shared space #944

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

KhaledNjim
Copy link
Collaborator

@KhaledNjim KhaledNjim commented Feb 21, 2024

Description

GitLab issue

Root cause

Flutter_downloader requires saveInPublicStorage flag to be set to true for devices with android version greater than android Q(10) to be able to save in downloads folder

Solution

Set the saveInPublicStorage flag to true in the Flutter_Downloader call in Download_document method

@hoangdat
Copy link
Member

please describe the root cause and your solution, hope it easier for review.

@KhaledNjim
Copy link
Collaborator Author

@hoangdat done

@hoangdat
Copy link
Member

hoangdat commented Feb 27, 2024

  • try to add more video demos:
    • with android 31
    • with android 33

@hoangdat
Copy link
Member

  • beside download with FlutterDownloader, we also have LinShareDownloadManager work with Dio to support download too, please take care of it also

@KhaledNjim
Copy link
Collaborator Author

Android 31

api31.mp4

Android 33

for android 33 the notification in not working(#910) but the file is downloaded

api33.mp4

@KhaledNjim
Copy link
Collaborator Author

  • beside download with FlutterDownloader, we also have LinShareDownloadManager work with Dio to support download too, please take care of it also

I have checked it and it works as intended

@hoangdat hoangdat merged commit cefc973 into master Apr 1, 2024
4 checks passed
@hoangdat hoangdat deleted the bugFix/cannot_download_files_from_my_space branch April 1, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants