Magic attachments #1466
Merged
Magic attachments #1466
+228
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also it would need code reorganisation so that reusable pieces can benefit the PG app, for instance... |
chibenwa
force-pushed
the
magic-attachments
branch
from
d4626cc to
a6a9390
Compare
Ease writing custom logic for this a LOT
chibenwa
force-pushed
the
magic-attachments
branch
from
7d4afca to
125f053
Compare
|
Needs apache/james-project#2622 Local simple perf tests results: a message with 60 attachments. Before downloading one took ~100 ms (knowing this shows only part of the improvment as on the testing S3 data is held in memory) |
|
TODO
|
Arsnael
approved these changes
Feb 6, 2025
|
Not sure why the github UI isn't updated but green on the CI. An other review perhaps? |
|
It turned out build is green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very WIP
I need to:
TMailCleverMailboxSessionMapperFactorywhich makes for halth of the code base added hereSee the related James PR