Fix jmap request to server is called when query string is empty in quick search web #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been deployed to https://linagora.github.io/tmail-flutter/3276. |
tddang-linagora
previously approved these changes
Nov 15, 2024
|
…y in quick search web
Fixed. Screen.Recording.2024-11-18.at.01.44.15.mov
Currently, we don't have integration test on web. |
core/lib/presentation/views/quick_search/quick_search_suggestion_list.dart
Show resolved
Hide resolved
…is empty in quick search web
tddang-linagora
previously approved these changes
Nov 18, 2024
hoangdat
previously approved these changes
Nov 18, 2024
hoangdat
reviewed
Nov 18, 2024
|
|
||
| Future<Iterable<P>?> _getListContact(String queryString) async { | ||
| try { | ||
| return widget.contactSuggestionCallback?.call(queryString); |
hoangdat
reviewed
Nov 18, 2024
|
|
||
| Future<Iterable<T>?> _getListSuggestion(String queryString) async { | ||
| try { | ||
| return widget.suggestionsCallback?.call(queryString); |
hoangdat
reviewed
Nov 18, 2024
|
|
||
| Future<Iterable<R>?> _getListRecent(String queryString) async { | ||
| try { | ||
| return widget.fetchRecentActionCallback?.call(queryString); |
…string is empty in quick search web
dab246
dismissed stale reviews from hoangdat and tddang-linagora
via
7c12ae3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
issue-jmap-called-when-search-empty.mov
Root cause
Timerto debounce, but it doesn't work properly.Solution
-Using debounce_throttle to debounce
Resolved
Screen.Recording.2024-11-15.at.15.35.08.online-video-cutter.com.mp4