Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-2948 Apply new identity view #3322

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

dab246
Copy link
Member

@dab246 dab246 commented Dec 4, 2024

Issue

#2948

Resolved

  • Web:
Screen.Recording.2024-12-04.at.16.36.18.mov
  • Mobile:
demo-android.webm

dab246 and others added 22 commits November 25, 2024 18:24
Copy link

github-actions bot commented Dec 4, 2024

This PR has been deployed to https://linagora.github.io/tmail-flutter/3322.

tddang-linagora
tddang-linagora previously approved these changes Dec 5, 2024
@hoangdat
Copy link
Member

  • it is nested scroll in this screen (both mobile/web), it makes user sometime hared to scroll, especially in mobile. So I propose to disable scroll for preview signature, fixed height for this. WDYT?
    image

@hoangdat
Copy link
Member

  • Create new profile button is moving up when identity list loading. Should keep it pins to bottom of screen
image

@hoangdat hoangdat dismissed tddang-linagora’s stale review February 5, 2025 11:06

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants