✨ Load pages and ensure scrollbar is always visible #760
Conversation
|
I'm just a bit curious about some more esoteric scenarios: you load a first page, it has a scrollbar, font too big you zoom out, no more scroll bar =D I think we can let it be since a refresh fixes it |
@ericlinagora I just updated it so it does try to ensure the scroll bar is in view when the window is re-sized; |
| if (scrollTop > 0 && scrollTop + clientHeight >= scrollHeight) { | ||
| await loadNextPage(parentId); | ||
| } | ||
| }; | ||
|
|
||
| useEffect(() => { | ||
| if(!loading) scrollViwer.current?.addEventListener('scroll', handleScroll, { passive: true }); | ||
| if (!loading) | ||
| scrollViewer.current?.addEventListener('scroll', handleScroll, { passive: true }); |
There was a problem hiding this comment.
Everything looks good to me, but have you considered replacing the scroll event with the Intersection Observer API in the future? I saw that the scroll event triggers even when the scrollbar hasn’t reached the target point.
There was a problem hiding this comment.
I didn't know about that API, looks great thanks
ericlinagora
deleted the
755-when-the-first-page-of-items-loads-without-needing-a-scrollbar-no-way-to-get-to-second-page
branch
No description provided.