probe and diagnostic endpoints #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericlinagora
force-pushed
the
762-probe-and-diagnostic-endpoints
branch
from
d27b2f9 to
932aa55
Compare
ericlinagora
force-pushed
the
762-probe-and-diagnostic-endpoints
branch
from
932aa55 to
dab4d0e
Compare
shepilov
reviewed
Dec 9, 2024
shepilov
reviewed
Dec 9, 2024
shepilov
reviewed
Dec 9, 2024
tdrive/backend/node/src/core/platform/services/storage/oneof-storage-strategy.ts
Show resolved
Hide resolved
shepilov
reviewed
Dec 9, 2024
tdrive/backend/node/src/core/platform/services/diagnostics/providers/process.ts
Show resolved
Hide resolved
shepilov
reviewed
Dec 9, 2024
| case TServiceDiagnosticDepth.stats_deep: | ||
| return { | ||
| ok: true, | ||
| databases: (await this.client.query("select * from pg_stat_database")).rows, |
There was a problem hiding this comment.
If you are running this query not from database owner, your user should have permissions to pg_stat_database, if it's possible it would be great to catch this exception here, and translate it explicitly to clients error
shepilov
reviewed
Dec 9, 2024
shepilov
reviewed
Dec 9, 2024
tdrive/backend/node/src/core/platform/services/diagnostics/web/probe-routes.ts
Show resolved
Hide resolved
shepilov
reviewed
Dec 9, 2024
tdrive/backend/node/src/core/platform/services/diagnostics/web/probe-routes.ts
Show resolved
Hide resolved
shepilov
reviewed
Dec 9, 2024
tdrive/backend/node/src/core/platform/services/diagnostics/web/heap-routes.ts
Outdated
Show resolved
Hide resolved
ericlinagora
force-pushed
the
762-probe-and-diagnostic-endpoints
branch
from
12ff9ae to
633f8ff
Compare
… fastify upgrade (#762)
shepilov
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basic lifecycle probes for kubes and an endpoint for diagnosing mem leaks
missing tests for av, message queue, possibly sso