Add testid into checkable icon, file version rows #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericlinagora
requested changes
Jan 15, 2025
| } | ||
| > | ||
| <div className="grow text-ellipsis whitespace-nowrap overflow-hidden"> | ||
| <Base>{version.file_metadata.name}</Base> | ||
| <Base className="testid:version-name">{version.file_metadata.name}</Base> |
There was a problem hiding this comment.
there's no need to repeat the parent name, finding this row would be easy with .version-row .name too
| @@ -33,6 +33,7 @@ export function Select(props: InputProps) { | |||
| style={styles} | |||
| className={inputClassName + ' ' + props.className} | |||
| {..._.omit(props, 'label', 'className', 'size')} | |||
| data-value={props.value} | |||
There was a problem hiding this comment.
try and read this is as a user would, we should have as little as possible that is only needed by tests
lethemanh
force-pushed
the
fix/add-more-test-id
branch
from
78ed76e to
fd84082
Compare
lethemanh
changed the title
lethemanh
force-pushed
the
fix/add-more-test-id
branch
from
fd84082 to
863f6f5
Compare
ericlinagora
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.