🐛 [in brackets] back: immediately start streaming downloading of zip #783 #788
+67
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericlinagora
changed the title
ericlinagora
force-pushed
the
783-bug-err_connection_close-when-downloading-a-zip-of-a-folder-with-a-great-many-number-of-files
branch
from
ce89235 to
c39bdd9
Compare
shepilov
reviewed
Jan 24, 2025
| @@ -345,6 +345,9 @@ export const addDriveItemToArchive = async ( | |||
| id: string, | |||
| entity: DriveFile | null, | |||
| archive: archiver.Archiver, | |||
| beginArchiveTransmit: | |||
There was a problem hiding this comment.
I love this, string or function, do you miss void*?)
There was a problem hiding this comment.
lol, no that's just object. Here i want to make sure it's not called with a falsy/null/undef value if it isn't done only for the reason of passing the call having happened down the recursion
shepilov
approved these changes
Jan 24, 2025
ericlinagora
deleted the
783-bug-err_connection_close-when-downloading-a-zip-of-a-folder-with-a-great-many-number-of-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading a folder with a great many entries below, time to first byte can cause a tcp disconnection for timeout by a reverse proxy, this starts the download asap, and ignores unreadable entries because of AV or rights. It tries to generate a valid zip even if some entries are missing for those reasons