Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-888: Add unit test for ContactsManager #1008

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

nqhhdev
Copy link
Member

@nqhhdev nqhhdev commented Nov 19, 2023

No description provided.

Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1008

@nqhhdev nqhhdev force-pushed the unit-test-for-contacts-manager branch from 215a0a6 to f9e2ef9 Compare November 19, 2023 18:27
@drminh2807
Copy link
Contributor

drminh2807 commented Nov 20, 2023

It good for Unit Test of Contact Manger
but cant test the Interactor
what do you think if we create Intergration test
just mock the datasource, then can test Repo, Interactor, ContactManger together
we don't write much test for now, so write 1 test can wrap many cases maybe better

@nqhhdev nqhhdev force-pushed the synchronize-contact branch from 637be01 to 73a9373 Compare November 20, 2023 09:14
Base automatically changed from synchronize-contact to main November 20, 2023 09:50
@nqhhdev nqhhdev force-pushed the unit-test-for-contacts-manager branch from 02dfee4 to eb4c5ca Compare November 21, 2023 02:25
@hoangdat
Copy link
Member

please rebase it

@nqhhdev nqhhdev force-pushed the unit-test-for-contacts-manager branch from 6c602bb to 8b9fbc0 Compare February 1, 2024 03:30
@nqhhdev
Copy link
Member Author

nqhhdev commented Feb 1, 2024

please rebase it

Done

@hoangdat hoangdat merged commit 66943eb into main Feb 1, 2024
3 checks passed
@hoangdat hoangdat deleted the unit-test-for-contacts-manager branch February 1, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants