TW-762: quoted image message #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imGok
requested review from
sherlockvn,
hoangdat,
dab246,
nqhhdev and
drminh2807
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1019 |
imGok
force-pushed
the
TW-762-quoted-image-message
branch
from
eb4bbb6 to
54197e9
Compare
imGok
changed the title
imGok
force-pushed
the
TW-762-quoted-image-message
branch
from
54197e9 to
a485c3d
Compare
hoangdat
reviewed
Nov 23, 2023
lib/widgets/mxc_image.dart
Outdated
Comment on lines
237
to
238
| width: widget.width ?? 256, | ||
| height: widget.height ?? 256, |
There was a problem hiding this comment.
Why don't you set placeholder in where you use, instead of change the MxcImage
drminh2807
reviewed
Nov 23, 2023
| isThumbnail: true, | ||
| width: ReplyContentStyle.fontSizeDisplayContent * 2, | ||
| height: ReplyContentStyle.fontSizeDisplayContent * 2, | ||
| fit: BoxFit.cover, |
There was a problem hiding this comment.
should add placeholder is BlurHash of event
sherlockvn
reviewed
Nov 23, 2023
| if (displayEvent.hasAttachment) | ||
| ClipRRect( | ||
| borderRadius: ReplyContentStyle.previewedImageBorderRadius, | ||
| child: MxcImage( |
There was a problem hiding this comment.
i mean set placeholder here
|
some images is resized, i think you should crop it |
sherlockvn
reviewed
Nov 23, 2023
lib/widgets/mxc_image.dart
Outdated
| key: Key(placeholderKey), | ||
| child: CircularProgressIndicator.adaptive(), | ||
| SizedBox( | ||
| width: widget.width ?? 256, |
There was a problem hiding this comment.
remove the default size 256, it will make image resize
imGok
force-pushed
the
TW-762-quoted-image-message
branch
2 times, most recently
from
a5b98ac to
e3da172
Compare
imGok
force-pushed
the
TW-762-quoted-image-message
branch
from
e3da172 to
67fc2bd
Compare
imGok
force-pushed
the
TW-762-quoted-image-message
branch
from
67fc2bd to
14056a5
Compare
|
up to date |
|
Please update your demo on other size of images |
@sherlockvn please share him the image test sets which we do before. Thanks |
Expected:
Actual:
###
- So, to avoid the image resize, you should use ImageBubble, it has an option for noResize
|
MxcImage also have |
|
|
sherlockvn
approved these changes
Nov 27, 2023
|
IMO: Remove small icon in descriptions, WDYT? |
drminh2807
approved these changes
Nov 28, 2023
hoangdat
pushed a commit
that referenced
this pull request
Nov 28, 2023
hoangdat
pushed a commit
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twake.Chat.-.Google.Chrome.2023-11-22.11-07-08.mp4
#762