TW-1135: preserve users linebreaks in message content #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imGok
requested review from
sherlockvn,
hoangdat,
dab246 and
nqhhdev
as code owners
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1277 |
hoangdat
reviewed
Jan 5, 2024
sherlockvn
previously approved these changes
Jan 5, 2024
hoangdat
force-pushed
the
TW-1135-linebreaks-pubspeclock
branch
from
e65179d to
077915f
Compare
hoangdat
force-pushed
the
TW-1135-linebreaks-pubspeclock
branch
from
077915f to
644086c
Compare
|
I tested, it not work well, please show the demo. |
imGok
force-pushed
the
TW-1135-linebreaks-pubspeclock
branch
from
644086c to
44b715b
Compare
imGok
changed the title
imGok
force-pushed
the
TW-1135-linebreaks-pubspeclock
branch
from
44b715b to
b5507b6
Compare
|
@hoangdat I confirm it's working on my side after cleaning all libs etc. the deployment is not updated |
|
Work from my side |
|
Error when i try: |
It's because we trim the string, it's intentional. @hoangdat do we remove it ? |
|
@sherlockvn Twake.Chat.-.Google.Chrome.2024-01-11.15-13-47.mp4 |
|
Okay i can confirm it's work from my side too |
imGok
force-pushed
the
TW-1135-linebreaks-pubspeclock
branch
from
9e82783 to
4ec9b23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linagora/flutter_matrix_html#12
linagora/matrix-dart-sdk#42
Demo
Twake.Chat.-.Google.Chrome.2024-01-09.17-17-04.mp4
Linebreaks proofs
#1135