Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maked z mandatory in training set type. #393

Merged
merged 1 commit into from
Feb 11, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 34 additions & 13 deletions backend/core/views/product.py
Original file line number Diff line number Diff line change
Expand Up @@ -339,30 +339,51 @@ def partial_update(self, request, *args, **kwargs):
instance = self.get_object()
data = request.data

check_columns = {"Dec": False, "RA": False, "z": False}

prodstatus = int(data.get("status", 0))
is_spec = instance.product_type.name == "specz_catalog"
is_published = ProductStatus(prodstatus).name == "PUBLISHED"

is_specz = instance.product_type.name == "specz_catalog"
is_train = instance.product_type.name == "training_set"

logger.debug(f"Status: {prodstatus}")
logger.debug(f"IsSpec: {is_spec}")
logger.debug(f"IsPubl: {is_published}")

if is_spec and prodstatus and is_published:
for prodcont in ProductContent.objects.filter(product=instance.pk):
if prodcont.alias in check_columns:
check_columns[prodcont.alias] = True
if is_specz and prodstatus and is_published:
check_specz = self.__check_mandatory_columns(instance, ["Dec", "RA", "z"])

if not check_specz.get("success", False):
content = check_train.get("message")
return Response(content, status=status.HTTP_406_NOT_ACCEPTABLE)
elif is_train and prodstatus and is_published:
check_train = self.__check_mandatory_columns(instance, ["z"])

for key, value in check_columns.items():
if not value:
content = {"message": f"The {key} column was not filled."}
logger.info(f"MESSAGE: {content}")
return Response(content, status=status.HTTP_406_NOT_ACCEPTABLE)
if not check_train.get("success", False):
content = check_train.get("message")
return Response(content, status=status.HTTP_406_NOT_ACCEPTABLE)

instance.status = prodstatus
instance.save()

serializer = self.get_serializer(instance, data=data, partial=True)
serializer.is_valid(raise_exception=True)
return Response(serializer.data)

def __check_mandatory_columns(self, instance, columns):
"""Checks mandatory columns

Args:
instance (Product): Product object
columns (list): mandatory columns
"""

for prodcont in ProductContent.objects.filter(product=instance.pk):
if prodcont.alias in columns:
columns.remove(prodcont.alias)

if columns:
return {
"success": False,
"message": f"The column(s) was not filled in: {','.join(columns)}",
}

return {"success": True, "message": "Mandatory columns filled in."}
Loading