Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This month in Xilem, March 2024 #47

Merged
merged 6 commits into from
Apr 4, 2024
Merged

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Apr 4, 2024

@DJMcNab DJMcNab requested a review from raphlinus April 4, 2024 09:59
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I would do some minor tweaks.

content/blog/2024-04-04-tmix-03.md Outdated Show resolved Hide resolved
content/blog/2024-04-04-tmix-03.md Outdated Show resolved Hide resolved
content/blog/2024-04-04-tmix-03.md Outdated Show resolved Hide resolved
content/blog/2024-04-04-tmix-03.md Outdated Show resolved Hide resolved
content/blog/2024-04-04-tmix-03.md Outdated Show resolved Hide resolved
Comment on lines 4 to 6
+++

<!-- I don't think we need to set the date, as it is inferred from the slug -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be more conclusive with this.

Suggested change
+++
<!-- I don't think we need to set the date, as it is inferred from the slug -->
+++
<!-- The post's date is inferred from the file name. -->

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically, this is mostly just trying to get this comment thread, to see if we can get an explanation as to why the full date/time is set in the other posts.

I don't think it's useful to have in the final version, i.e.

Suggested change
+++
<!-- I don't think we need to set the date, as it is inferred from the slug -->
+++

Copy link
Member

@xStrom xStrom Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it's in the other posts because this feature was not known. Can see what Raph has to say about it I guess.

There's a tiny bit of value in having that comment stay so that future post writers can more easily figure out why the date suddenly doesn't appear. Not a big issue though as the set of writers here is very limited.

content/blog/2024-04-04-tmix-03.md Outdated Show resolved Hide resolved
content/blog/2024-04-04-tmix-03.md Show resolved Hide resolved
content/blog/2024-04-04-tmix-03.md Show resolved Hide resolved
content/blog/2024-04-04-tmix-03.md Show resolved Hide resolved
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GIFs are better than nothing, but what about linking to the web demo?

content/blog/2024-04-04-tmix-03.md Outdated Show resolved Hide resolved
[masonry#56]: https://github.com/PoignardAzur/masonry-rs/pull/56
[Android Trace]: https://github.com/linebender/android_trace
[Vello SVG]: https://github.com/linebender/vello_svg
[Velato]: https://github.com/linebender/velato
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Velato]: https://github.com/linebender/velato
[Velato]: https://github.com/linebender/velato
[web demo of Velato]: https://linebender.org/velato/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My one concern here is that this might not be a cool URL - if we ever have an actual page for Velato, that would be the probably URL. It frustrates me that https://linebender.github.io/velato redirects to this URL, when it would be better as the former, because we can be fairly sure that will be stable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this URL is probably destined to rot. It's unfortunate but not the worst thing for the purposes of this post. The URL is likely to keep working as-is for a few months and when we do introduce an actual product page it will probably have some sort of link in it to the web demo. So not ideal, but better than a 404 or DNS_PROBE_FINISHED_NXDOMAIN.

Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's publishable now. Thanks for making this happen. 🎉

@DJMcNab
Copy link
Member Author

DJMcNab commented Apr 4, 2024

I'll let @raphlinus press the merge button on this one (or at least wait for his approval)

Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for taking it on, and thanks to Kaur for the thoughtful review.

@DJMcNab DJMcNab merged commit 3edfb16 into linebender:main Apr 4, 2024
1 check passed
@DJMcNab DJMcNab deleted the tmix-april-2024 branch April 4, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants