Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "three-months roadmap" article #52

Merged
merged 12 commits into from
Jun 17, 2024
Merged

Create "three-months roadmap" article #52

merged 12 commits into from
Jun 17, 2024

Conversation

PoignardAzur
Copy link
Contributor

@PoignardAzur PoignardAzur commented May 23, 2024

@DJMcNab

This comment was marked as outdated.

content/blog/2024-05-23-linebender-roadmap.md Outdated Show resolved Hide resolved
content/blog/2024-05-23-linebender-roadmap.md Outdated Show resolved Hide resolved
content/blog/2024-05-23-linebender-roadmap.md Outdated Show resolved Hide resolved
content/blog/2024-05-23-linebender-roadmap.md Outdated Show resolved Hide resolved
@PoignardAzur PoignardAzur marked this pull request as ready for review June 12, 2024 17:18
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think it will be really good to share this. A handful of details and potential additions, but nothing huge to change

Also, please move this to one sentence per line, including in the roadmap items; I believe bullet points in markdown properly support non-semantic newlines.

content/blog/2024-05-23-linebender-roadmap.md Outdated Show resolved Hide resolved
content/blog/2024-05-23-linebender-roadmap.md Outdated Show resolved Hide resolved

- **Priority:** Highest.
- **Assigned:** Olivier Faure, Aaron Muir Hamilton.
- **Description:** We'd like to bring up Masonry's textbox widget to be best-in-class among Rust frameworks. We want to support native-feeling interactions out of the box, such as cursor movement (go to next word, go to beginning of line), selection (select to end of text) and edition (IME, deleting an entire word, etc). This is something other framework developers have expressed interest in, so we want to implement it in a composable way.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One sentence per line please.
Also edition should probably be editing?


What follows is a comprehensive summary of what exactly we're planning to do.
We've tried to focus on blockers, where a missing feature in one project is stalling progress on other projects, because those are the hardest barriers to coordination, and we wanted to take advantage of being in the same room together to knock them down.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have a sentence here that this document will not be updated with the current status, and so includes both planned and completed work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this is partially reflected in the conclusion, but I still think it would also be useful to have a similar preface

content/blog/2024-05-23-linebender-roadmap.md Outdated Show resolved Hide resolved
- **Priority:** High.
- **Assigned:** Nico Burns.
- **Description:** Parley currently has virtually no documentation. If we want it to become a fundational crate, we need to explain to people how to use it.
- **PR:** [parley#26](https://github.com/linebender/parley/pull/26)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really should try and just merge this "as-is"; it's not doing any good just sat as a draft.

content/blog/2024-05-23-linebender-roadmap.md Outdated Show resolved Hide resolved
content/blog/2024-05-23-linebender-roadmap.md Outdated Show resolved Hide resolved
Comment on lines 245 to 246
As we fill out gaps in our feature set, Xilem is moving closer to becoming a stable, mature framework for writing GUI applications.
We're not GUI yet, but we hope we'll be in the near future.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is potentially "promising" more than we're willing to give (especially considering Raph's question answer in the RustNL talk). I like the optimistic sentiment.

I'd maybe rephrase it in terms of "filling out the features needed for Xilem to thrive"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the wording a bit to make it more of a "north star" thing.

content/wiki/long-term-roadmap.md Show resolved Hide resolved
@PoignardAzur PoignardAzur changed the title TMP: Add draft of roadmap article Create "three-months roadmap" article Jun 13, 2024
@PoignardAzur
Copy link
Contributor Author

Also, please move this to one sentence per line, including in the roadmap items; I believe bullet points in markdown properly support non-semantic newlines.

I really don't want to do that unless you think it's critical to stick to this standard.

Honestly, I'm skeptical of the one-sentence-per-line rule. So far the only result of that rule for me has been having to rewrite more stuff. I get that it's supposed to make diffs more readable for large paragraphs, but it also makes the document itself less readable and more annoying to write. When it comes to bullet points, writing them as one paragraph is natural and writing them one sentence per line needs even more fiddling.

It would be one thing if we had a canonical formatter that applied this rule, or if this was a living document that was going to see more diffs, but it's a blog post that will never be touched again after it's posted.

@DJMcNab
Copy link
Member

DJMcNab commented Jun 13, 2024

The one sentence per line thing is mostly for the sake of reviewing - not having it makes it harder to add specific comments about specific sentences, because GitHub doesn't let us comment on a range more fine-grained than a line. It means we have to do really awkward things like quoting a sentence within a paragraph to comment on it.
For the current state of this, it's fine as there is unlikely to be any more significant review, but I do think it makes reviewing text content much easier.

I'm not sure what we want the approval process for this to be; I think it's fine to land as-is, but maybe Raph will want to take a look?

@Philipp-M
Copy link

Philipp-M commented Jun 13, 2024

but it also makes the document itself less readable and more annoying to write.

Isn't it rendered the same as without?

Btw. regarding rendering, to keep the link in the first post up-to-date (when the filename doesn't change at least), I'd suggest using something like:

https://github.com/linebender/linebender.github.io/blob/roadmap/content/blog/2024-05-23-roadmap-may-2024.md

(i.e. change the commit hash with the branch name, though this has problems, when it's merged and the branch is deleted obviously)


On May 7 and 8, 2024, folks from the Linebender team went to [the RustNL conference](https://2024.rustnl.org/) for two days, followed by two days of Unconference.

By that point, we all felt fairly exhausted, but Raph Levien being the cruel taskmaster that he is, he still made us work one extra day, and so we came together in our hotel's conference room to discuss the Linebender project, and what we wanted from it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this is a joke. However a surprising number of people failed to understand that Raph's April 1st C++ post was a joke and that was a much more obvious joke. For that reason I recommend against using our blog for such banter, as too many people will take it literally.

Suggested change
By that point, we all felt fairly exhausted, but Raph Levien being the cruel taskmaster that he is, he still made us work one extra day, and so we came together in our hotel's conference room to discuss the Linebender project, and what we wanted from it.
By that point, we all felt fairly exhausted, but we still came together in our hotel's conference room to discuss the Linebender project, and what we wanted from it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm conflicted on this; I think it's probably right to remove it, but I wish it wasn't 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that joke was funnier when I wrote it right after hell week. ^^

I'll soften it a bit, and make the joke framing more obvious.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Also, that joke is a lot funnier when you know Raph and how laid back he is, but people reading a blog post probably won't know that, so the framing should be obvious.)

@PoignardAzur
Copy link
Contributor Author

I've fixed small errors and sanded down the more controversial/risky bits. I think this is ready to publish now.

@PoignardAzur PoignardAzur requested review from xStrom and DJMcNab June 15, 2024 11:29
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think it's important not to let this slip farther, since we are (today) half way through the discussed period.

* Accessibility isn’t just screen readers. Also color contrast, customizing size, IME support, motor disabilities (avoid stuff that requires simultaneous input).

* “Accessibility is more than adding a dependency to AccessKit”
* (Olivier: Note to self: include GMTK video about Celeste Assist Mode)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be handled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe if I get around to writing an article about accessibility. In the meantime, those are unstructured notes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File date probably needs to change

@PoignardAzur
Copy link
Contributor Author

PoignardAzur commented Jun 15, 2024

Will publish this on Monday (and change the date then), to leave some breathing room between the two articles.

@PoignardAzur PoignardAzur merged commit 6fb7486 into main Jun 17, 2024
1 check passed
@PoignardAzur PoignardAzur deleted the roadmap branch June 17, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants