Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load polyfill.min.js from cdnjs #66

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

valadaptive
Copy link
Contributor

Resolves #65.

As mentioned in the above issue, polyfill.io is now being used to host a supply-chain attack. I've replaced the polyfill.io URL with a replacement hosted on cdnjs.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bringing this to our attention!

@@ -21,7 +21,7 @@
<link type="application/atom+xml" rel="alternate" href="/{{config.feed_filename}}" title="{{config.title}}">
{% endif %}
<!-- mathjax support -->
<script src="https://polyfill.io/v3/polyfill.min.js?features=es6"></script>
<script src="https://cdnjs.cloudflare.com/polyfill/v3/polyfill.min.js?features=es6"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<script src="https://cdnjs.cloudflare.com/polyfill/v3/polyfill.min.js?features=es6"></script>

According to upstream MathJax, this is only needed for IE11 support.
Let's just remove it entirely.

@DJMcNab DJMcNab merged commit e411cc6 into linebender:main Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove scripts loaded from polyfill.io
2 participants