Skip to content

Commit

Permalink
Simplify MSRV Wasm testing configuration in CI. (#730)
Browse files Browse the repository at this point in the history
`cargo-hack` has gained the ability to use `--exclude` along with `-p`
in [cargo-hack#258](taiki-e/cargo-hack#258).
This allows us to simplify our CI configuration.
  • Loading branch information
xStrom authored Nov 3, 2024
1 parent 588305a commit f24c57e
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,11 @@ env:
# List of packages that will be checked with the minimum supported Rust version.
# This should be limited to packages that are intended for publishing.
RUST_MIN_VER_PKGS: "-p vello -p vello_encoding -p vello_shaders"
# List of packages that can not target wasm.
# `vello_tests` uses `nv-flip`, which doesn't support wasm.
# List of packages that can not target Wasm.
# `vello_tests` uses `nv-flip`, which doesn't support Wasm.
NO_WASM_PKGS: "--exclude vello_tests --exclude simple_sdl2"



# Rationale
#
# We don't run clippy with --all-targets because then even --lib and --bins are compiled with
Expand Down Expand Up @@ -349,9 +348,7 @@ jobs:
tool: cargo-hack

- name: cargo check
# We don't include ${{ env.NO_WASM_PKGS }} here, because `-p foo --exclude foo` doesn't work
# and none of our `NO_WASM_PKGS` have an MSRV.
run: cargo hack check ${{ env.RUST_MIN_VER_PKGS }} --locked --target wasm32-unknown-unknown --optional-deps --each-feature
run: cargo hack check ${{ env.RUST_MIN_VER_PKGS }} ${{ env.NO_WASM_PKGS }} --locked --target wasm32-unknown-unknown --optional-deps --each-feature

doc:
name: cargo doc
Expand Down

0 comments on commit f24c57e

Please sign in to comment.