Replace fello with skrifa for font rendering #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces our bespoke fello lib with skrifa from crates.io which brings us one step closer to being able to release. Causes a slight regression since we no longer support hinting but that will be fixed when support lands upstream (soon!)
Philipp-M
approved these changes
Jan 24, 2024
What is hinting? |
|
I think wikipedia does a good job explaining that. |
simbleau
approved these changes
Jan 24, 2024
| @@ -49,18 +51,16 @@ impl GlyphCache { | |||
| }; | |||
| encoding_cache.encode_fill_style(fill); | |||
| let mut path = encoding_cache.encode_path(true); | |||
| let outline = outlines.get(GlyphId::new(key.glyph_id as u16))?; | |||
| let draw_settings = skrifa::outline::DrawSettings::unhinted(size, coords); | |||
There was a problem hiding this comment.
Suggested change
| let draw_settings = skrifa::outline::DrawSettings::unhinted(size, coords); | |
| // FIXME: Re-add hinting when skrifa supports it | |
| let draw_settings = skrifa::outline::DrawSettings::unhinted(size, coords); |
There was a problem hiding this comment.
Sure, a little reminder won't hurt. Also added a link to the tracking issue.
The wikipedia article does a good job explaining the concept. Our fello crate does contain an implementation of hinting but it's not production quality. My current task at day job is making it so and landing it in skrifa so this should be done soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces our bespoke fello lib with skrifa from crates.io which brings us one step closer to being able to release.
Causes a slight regression since we no longer support hinting but that will be fixed when support lands upstream (soon!)