Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade naga dependency to 0.19 #515

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Upgrade naga dependency to 0.19 #515

merged 1 commit into from
Mar 10, 2024

Conversation

sepcnt
Copy link
Collaborator

@sepcnt sepcnt commented Mar 9, 2024

No description provided.

Copy link
Member

@simbleau simbleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, seems straight forward. However I think someone who works with the shaders more should approve too, e.g. @armansito . Was there a reason we were on naga 0.13? That seems... very old. I also assumed naga was included by wgpu already (if not as a feature?), so i'm equally confused.

@raphlinus
Copy link
Contributor

The shaders crate is primarily for Skia integration and is not directly consumed by Vello, though it should be (see #467). It definitely makes sense to bump this, as my new shader code makes use of constants and so that's a source of warnings on #496. It's possible that this will break some stuff on the Skia side, so it does make sense for @armansito to take another look.

Also, our policy is for the author to merge, so I'll turn on write access for @sepcnt.

Thanks!

@sepcnt sepcnt added this pull request to the merge queue Mar 10, 2024
Merged via the queue into linebender:main with commit 755fc5b Mar 10, 2024
18 checks passed
@waywardmonkeys
Copy link
Collaborator

I'll approve, seems straight forward. However I think someone who works with the shaders more should approve too, e.g. @armansito . Was there a reason we were on naga 0.13? That seems... very old. I also assumed naga was included by wgpu already (if not as a feature?), so i'm equally confused.

They skipped from release 0.14 to 0.19 when they folded it in with the wgpu release train and versioning.

@armansito
Copy link
Collaborator

Thank you for the change, the naga dependency was just stale and needed to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants