Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_shader on the engine doesn't return a failure. #564

Merged
merged 1 commit into from
May 3, 2024
Merged

add_shader on the engine doesn't return a failure. #564

merged 1 commit into from
May 3, 2024

Conversation

waywardmonkeys
Copy link
Collaborator

Simplify this by recognizing that Engine::add_shader won't return an Error so it doesn't need to return a Result.

@waywardmonkeys
add_shader on the engine doesn't return a failure.
c2eeb35 
Simplify this by recognizing that `Engine::add_shader` won't return
an `Error` so it doesn't need to return a `Result`.
@waywardmonkeys
Copy link
Collaborator Author

This is related to #516, but not handled there, as it removes things that claim they can return an error, but don't actually.

@waywardmonkeys
Copy link
Collaborator Author

Oops, this is handled there, but I'd like to land the Result changes separately from changing the error type and in a way where we can review them bit by bit and make sure they're the right thing.

DJMcNab
DJMcNab approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect the idea might have been for shaders to be "generic" over the engine being used, and some engines could reasonably have errors here.

But saying that, we don't have that set up, so this is fine.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue May 3, 2024
@waywardmonkeys waywardmonkeys added this to the Vello 0.2 release milestone May 3, 2024
Merged via the queue into linebender:main with commit 90d3514 May 3, 2024
15 checks passed
@waywardmonkeys waywardmonkeys deleted the engine-add-shader-no-result-type branch May 3, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Vello 0.2 release
Development

Successfully merging this pull request may close these issues.
2 participants
@waywardmonkeys @DJMcNab