Update to wgpu 24.0.0 #791
Conversation
|
@songhuaixu Thank you for this contribution! This leads us to an interesting issue which is that we haven't yet released a version that is compatible with Bevy, so we're going to need to hold on this at least until that happens: https://xi.zulipchat.com/#narrow/channel/197075-gpu/topic/wgpu.20v24.20released Is there a particular part of this update that you're in need of to have it sooner rather than a bit later? |
I can wait for Bevy |
| @@ -74,7 +74,7 @@ wasm-bindgen-futures = "0.4.45" | |||
| web-sys = { version = "0.3.72", features = ["HtmlCollection", "Text"] } | |||
| web-time = { workspace = true } | |||
| # If updating, also update in .github/workflows/web-demo.yml | |||
There was a problem hiding this comment.
Hmm. I'd expect this to apply to this update?
There was a problem hiding this comment.
Yes, I have already applied the update. The changes have been made and it should now work as expected.
| @@ -119,5 +119,6 @@ clap = "4.5.21" | |||
| anyhow = "1.0.93" | |||
| pollster = "0.4.0" | |||
| web-time = "1.1.0" | |||
| wgpu-profiler = "0.19.0" | |||
| #wgpu-profiler = "0.19.0" | |||
| wgpu-profiler = { git = "https://github.com/songhuaixu/wgpu-profiler.git", branch = "update-wgpu" } | |||
There was a problem hiding this comment.
We cannot merge this PR until wgpu-profiler makes a corresponding release, of course. I'd suggest marking this PR as draft to indicate that.
There was a problem hiding this comment.
Thank you for your reminder. I have already submitted the PR for wgpu-profiler. I will keep an eye on its progress and once the corresponding release is made, I will update this PR accordingly. In the meantime, I agree that marking this PR as draft is a good way to indicate that it's not ready to be merged yet. I will do that now.
vello/src/util.rs
Outdated
| dx12_shader_compiler, | ||
| gles_minor_version, | ||
| backend_options: wgpu::BackendOptions { | ||
| dx12: wgpu::Dx12BackendOptions { |
There was a problem hiding this comment.
I think that this is equivalent to BackendOptions::from_env_or_default
There was a problem hiding this comment.
I see. I have already made the changes, and now it is equivalent to BackendOptions::from_env_or_default
| @@ -42,6 +42,7 @@ pub fn translate(shader: &ShaderInfo) -> Result<String, naga_msl::Error> { | |||
| fake_missing_bindings: false, | |||
| bounds_check_policies: naga::proc::BoundsCheckPolicies::default(), | |||
| zero_initialize_workgroup_memory: true, | |||
| force_loop_bounding: true, | |||
There was a problem hiding this comment.
I agree with you. With force_loop_bounding: true, in the current version, it should be fine as it is.
No description provided.