xilem_web: Add async_repeat

[flosse]

No description provided.

[Philipp-M]

So the reason why this doesn't compile has to do with the two different Message types (as well as DynMessage). One being of xilem_core, which requires Send and the other of xilem_web which doesn't require Send (which is necessary to be interoperable with e.g. web_sys::Event). See other views of xilem_web for more details.

We should probably document this, make it more clear to distinct between those two, because I've also had rust-analyzer suggesting me xilem_core::Message while I did want to use crate::Message.

Hmm the error message is really aweful, I wonder if it's somehow possible to improve this...

[flosse]

So the reason why this doesn't compile has to do with the two different Message types (as well as DynMessage).

Thank you! Now it works 😄

[Philipp-M]

Thank you! Now it works 😄

Good to know, I hope it's the same issue with AfterBuild etc.

The clippy suggestion is pretty dumb why CI fails... As if an endless loop doesn't have any side-effects...

Anyway, that example is somewhat redundant, as that should be a use-case for the new interval view now.
(Also I don't think we should use async_repeat_raw in an example, it's IMO mostly a hack to be able to capture stuff.)

[flosse]

Anyway, that example is somewhat redundant, as that should be a use-case for the new interval view now.

But now I added the "abort handle", that might be specific to async tasks.

[Philipp-M]

Same here, looks mostly good, but I think we should strive towards documenting all this stuff at this point

[Philipp-M]

I wonder if we should call the example different (though it's most descriptive for the view at least), like interval or ping or (news-)ticker as was suggested here, and maybe add the alternative (interval) there as well, so that people don't come to the idea to use async_repeat, when their use case is interval. At the very least, it should mention interval for this use-case.

[flosse]

I renamed it to spawn_tasks, but that's probably not really appropriate either 🤔

[Philipp-M]

Apart of nits, looks good, nice job with the ShutdownSignal.

[flosse]

Apart of nits, looks good, nice job with the ShutdownSignal.

thank you 😊

[Philipp-M]

I think you should've received an invitation to contribute.

Our merge-policy is usually that the author merges (after approval from someone else).

Otherwise looks good, so feel free to merge.