Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fill_major_axis flex attribute #812

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PoignardAzur
Copy link
Contributor

PoignardAzur and others added 3 commits January 10, 2025 17:26
The setting on the view side remained when it was removed on the widget side. This removes the view setter, and removes the references to it.
@jaredoconnell
Copy link
Contributor

I fixed the stopwatch example and removed a stale reference to a function. However, this is not ready for merging. The design of the variable clock example needs to be fixed. It appears that things are taking up all available space individually when only the sum of things should take up all available space.
We'll need to look into how that example was designed and figure out the better alternative implementation.

@PoignardAzur
Copy link
Contributor Author

I fixed the stopwatch example

Shoot, I forgot to check examples.

It appears that things are taking up all available space individually when only the sum of things should take up all available space.

Yup, I had a lot of visual problems like this when I tried removing BoxConstraints::min, hence my trying a more piecemal approach.

It's weird that we get the problem here, though. Each timezone is constrained in a SizedBox with .height(72.), there shouldn't be a way for it to expand to available space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants