Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose line break parameter in label widget #817

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Expose line break parameter in label widget #817

merged 2 commits into from
Jan 16, 2025

Conversation

melix99
Copy link
Contributor

@melix99 melix99 commented Jan 11, 2025

No description provided.

DJMcNab
DJMcNab approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unfortunately conflicts with #806. In the current state of main, this would need to also update the Button view.

I don't expect you to do anything, but I'll fix it up and land it once #806 lands (currently awaiting review)

@DJMcNab DJMcNab self-assigned this Jan 16, 2025
@DJMcNab DJMcNab enabled auto-merge January 16, 2025 14:05
@DJMcNab DJMcNab added this pull request to the merge queue Jan 16, 2025
Merged via the queue into linebender:main with commit 2172d4d Jan 16, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees

@DJMcNab DJMcNab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melix99 @DJMcNab