-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][Verl] Add entropy loss to cross_entropy_loss
and fused_linear_cross_entropy_loss
#551
Draft
hongpeng-guo
wants to merge
10
commits into
main
Choose a base branch
from
hpguo/lce_add_entropy_loss
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongpeng Guo <[email protected]>
Signed-off-by: Hongpeng Guo <[email protected]>
Signed-off-by: Hongpeng Guo <[email protected]>
Signed-off-by: Hongpeng Guo <[email protected]>
Signed-off-by: Hongpeng Guo <[email protected]>
Signed-off-by: Hongpeng Guo <[email protected]>
hongpeng-guo
changed the title
[Feature] Add entropy loss to
[WIP][Feature][Verl] Add entropy loss to Jan 30, 2025
cross_entropy_loss
and fused_linear_cross_entropy_loss
cross_entropy_loss
and fused_linear_cross_entropy_loss
hongpeng-guo
changed the title
[WIP][Feature][Verl] Add entropy loss to
[WIP][Verl] Add entropy loss to Jan 30, 2025
cross_entropy_loss
and fused_linear_cross_entropy_loss
cross_entropy_loss
and fused_linear_cross_entropy_loss
Signed-off-by: Hongpeng Guo <[email protected]>
Signed-off-by: Hongpeng Guo <[email protected]>
Signed-off-by: Hongpeng Guo <[email protected]>
Signed-off-by: Hongpeng Guo <[email protected]>
Please add a unit test with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In RLHF workflows, such as verl, the actor forward function usually generates both losses of
cross_entropy_loss (-log_probs)
andentropy_loss
, the later was used to encourage the policy to be not over-deterministic.There is a real needs for a kernel that will generates both the two losses, with materializing the huge
logits
tensor. Liger-kernel'sfused_linear_cross_entropy_loss
already works well to generate thecross_entropy_loss
, but only calculating the second part of the loss, i.e., the entropy loss.This PR adds the
entropy
loss option to the existing FLCE loss, and work as one important step to support verl.cross_entropy.py::liger_cross_entropy_kernel
, both the loss and its gradient subject to input are calculated and stored;fused_linear_cross_entropy.py
,Testing Done
Made existing unit tests working; Adding new unittest WIP.
make test
to ensure correctnessmake checkstyle
to ensure code stylemake test-convergence
to ensure convergence