Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectify GHA CI workflow for s390x #2249

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

yasiribmcon
Copy link
Contributor

Summary

  1. Why: Currently GHA CI builds for s390x are failing consistently, blocking the CI workflow.
  2. What: Added correct way of running multiple instructions during docker run command, updated temurin image to 11-jdk so that it can be in sync with ubuntu-latest image and introduced continue-on-error due to intermittent test case failures on temurin container.

Expected Behavior

gradle build command should run inside the s390x emulated temurin container and should pass.

Actual Behavior

gradle command actually runs on ubuntu-latest(which is x86_64) image which may or may not fail based on ubuntu-latest's jdk version which keeps on updating.

Steps to Reproduce

  1. Check GHA CI build log for s390x

Known Workarounds

No

Additional evidence

  1. This issue is similar to Re-enable s390x build for CI #2209 which is happening on CircleCI instead of GHA, where we discussed that the gradle build command is actually running on x86_64 instead of s390x. But since this build takes 2.5+ hours to complete in CircleCI, i could not do the same as I got build timeout from CircleCI.
  2. Test cases are failing intermittently inside temurin container due to which i had to introduce continue-on-error flag, this would free up the GHA CI workflow.
  3. Build run with all test passing : https://github.com/yasiribmcon/cruise-control/actions/runs/13069196316/job/36466943768
  4. Build run with intermittent tests failing : https://github.com/yasiribmcon/cruise-control/actions/runs/13069196316

Categorization

  • documentation
  • bugfix
  • new feature
  • refactor
  • security/CVE
  • other

This PR resolves #2209

Updated temurin image to 11-jdk so that it can be in sync with ubuntu-latest image.
Added correct way of running multiple instructions during docker run command.
Added uname command in end to confirm that build ran on s390x.
Introduced continue-on-error due to intermittent test case failures on temurin container.

Signed-off-by: Yasir Ashfaq <[email protected]>
Copy link
Contributor

@CCisGG CCisGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yasiribmcon !

@CCisGG CCisGG merged commit e9bf2d5 into linkedin:main Feb 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable s390x build for CI
2 participants